Skip to content

Add count_records method to allow easier override for non activerecor… #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgebhardt merged 2 commits into from
May 31, 2016
Merged

Add count_records method to allow easier override for non activerecor… #720

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e06b444
Add count_records method to allow easier override for non activerecor…
lgebhardt May 24, 2016
0bcde39
Use `count_records` method for counting records instead of AR count m…
lgebhardt May 25, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/jsonapi/processor.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ def show_related_resources
records = resource_klass.filter_records(filters, {},
related_resource_records)

record_count = records.count(:all)
record_count = resource_klass.count_records(records)
end

if (JSONAPI.configuration.top_level_meta_include_page_count && record_count)
Expand Down
7 changes: 6 additions & 1 deletion lib/jsonapi/resource.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -628,8 +628,13 @@ def sort_records(records, order_options, context = {})
apply_sort(records, order_options, context)
end

# Assumes ActiveRecord's counting. Override if you need a different counting method
def count_records(records)
records.count(:all)
end

def find_count(filters, options = {})
filter_records(filters, options).count(:all)
count_records(filter_records(filters, options))
end

# Override this method if you have more complex requirements than this basic find method provides
Expand Down