Skip to content

fix polymorphic_type for ToOne relationships #728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
barelyknown merged 1 commit into from
May 31, 2016
Merged

fix polymorphic_type for ToOne relationships #728

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/jsonapi/relationship.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,7 +74,7 @@ def belongs_to?
end

def polymorphic_type
"#{type.to_s.singularize}_type" if polymorphic?
"#{name}_type" if polymorphic?
end
end

Expand Down
12 changes: 12 additions & 0 deletions test/unit/resource/relationship_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
require File.expand_path('../../../test_helper', __FILE__)

class HasOneRelationshipTest < ActiveSupport::TestCase

def test_polymorphic_type
relationship = JSONAPI::Relationship::ToOne.new("imageable",
polymorphic: true
)
assert_equal(relationship.polymorphic_type, "imageable_type")
end

end