Merged
Conversation
6 tasks
| # Relationship reflection invokes the related resource when updates | ||
| # are made to a has_many relationship. By default relationship_reflection | ||
| # is turned off because it imposes a small performance penalty. | ||
| self.use_relationship_reflection = false |
Contributor
There was a problem hiding this comment.
Should be config.use_relationship_reflection = false ?
Contributor
Author
There was a problem hiding this comment.
Are you asking if the default should be to keep use_relationship_reflection set to true?
lgebhardt
force-pushed
the
reflect_relationship
branch
from
4e798c9 to
1fc4e64
Compare
| # Relationship reflection invokes the related resource when updates | ||
| # are made to a has_many relationship. By default relationship_reflection | ||
| # is turned off because it imposes a small performance penalty. | ||
| self.use_relationship_reflection = false |
Contributor
There was a problem hiding this comment.
Sorry, I mean self should be config.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #727