Fix code example for relationship specific method definitions#822
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom Sep 12, 2016
Merged
Conversation
There is no such method or variable as `relationship` defined in the
special record_for_#{relationship} method. For the commented-out code
to actually work, we first need to fetch the relationship object before
we can ask for the relation name.
Contributor
|
@valscion Thanks! I'm open to ideas for making the |
Contributor
Author
Yeah, I'll think about it and open an issue when/if I have something to share |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no such method or variable as
relationshipdefined in thespecial record_for_#{relationship} method. For the commented-out code
to actually work, we first need to fetch the relationship object before
we can ask for the relation name.
We could also discuss whether these special methods could somehow also have the
relationshipalready available to them, so that changes like these wouldn't be necessary.