Don't call link_builder when custom link is provided#826
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom Sep 12, 2016
Merged
Conversation
Contributor
|
@knapo Thanks! |
knapo
deleted the
dont-call-link-builder-when-custom-self-is-present
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
So I wan't to override
selflink usingcustom_links(make it nil since I don't need it for embedded relationship). However, for current implementation link builder is being called anyway and I need to define route which is never used, and it make the serialization slower as the route generation is not the fastest thing in rails.