Skip to content

Handle all base spec requests as a single operation#845

Merged
dgeb merged 1 commit intoJSONAPI-Resources:masterfrom
lgebhardt:base_spec_single_ops
Sep 22, 2016
Merged

Handle all base spec requests as a single operation#845
dgeb merged 1 commit intoJSONAPI-Resources:masterfrom
lgebhardt:base_spec_single_ops

Conversation

@lgebhardt
Copy link
Copy Markdown
Contributor

Getting ready for multiple operation support in requests

Also removes the feature of creating and modifying multiple resources as this is not compatible with final version of the JSON API spec.

Comment thread lib/jsonapi/processor.rb Outdated
@@ -13,7 +13,7 @@ class Processor
:replace_polymorphic_to_one_relationship,
:create_to_many_relationship,
:replace_to_many_relationship,
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like replace_to_many_relationship should now be replace_to_many_relationships and create_to_many_relationship should now be create_to_many_relationships for consistency.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Fixed.

Getting ready for multiple operation support in requests
(cherry picked from commit ff8b0c9)
@dgeb dgeb merged commit e30c43d into JSONAPI-Resources:master Sep 22, 2016
@lgebhardt lgebhardt deleted the base_spec_single_ops branch September 22, 2016 12:40
@valscion
Copy link
Copy Markdown
Contributor

valscion commented Oct 1, 2016

Ooh, interesting! I guess this'll break jsonapi-authorization, but patching for this change shouldn't be a big deal.

I didn't quite get what you meant with this:

Also removes the feature of creating and modifying multiple resources as this is not compatible with final version of the JSON API spec.

Was this something like sending an array of objects in POST payload (i.e. data in root was array) that was dropped? If so, I didn't even know JR had handled them 😅

@lgebhardt
Copy link
Copy Markdown
Contributor Author

@valscion Yes, it used to accept an array of objects in the payload. That was a feature from before the JSON API spec was finalized and I missed removing it.

Sorry about the churn breaking jsonapi-authorization. I suspect more breaking changes will be coming with the new operations support.

@valscion
Copy link
Copy Markdown
Contributor

valscion commented Oct 5, 2016

No worries, we've got our specs on the nice reques layer so upgrading is quite easy. I'm really looking forward to new operations support, our app would benefit from them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants