Skip to content

Remove rails as dependency#860

Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom
quinn:master
Oct 7, 2016
Merged

Remove rails as dependency#860
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom
quinn:master

Conversation

@quinn
Copy link
Copy Markdown
Contributor

@quinn quinn commented Oct 4, 2016

(this is a work in process probably...)

  • remove 'rails/all' from test helper
  • vender minitest-spec-rails
  • add activerecord and railties to gemspec

@lgebhardt
Copy link
Copy Markdown
Contributor

Thanks. I'd like to avoid needing to vendor minitest-spec-rails. Without it the tests seem to pass for rails 5, but not 4.2.

@quinn
Copy link
Copy Markdown
Contributor Author

quinn commented Oct 4, 2016

@lgebhardt yeah that's reasonable. I wanted to confirm that nothing would break in the test suite if the other parts of rails were included (even after removing rails, it was all still being pulled in by minitest-spec-rails).

Not sure what you mean by "without it", but I'll push again with the vendored stuff removed and add back into the gemspec

@quinn
Copy link
Copy Markdown
Contributor Author

quinn commented Oct 4, 2016

(i tested again on 4.2 as well)

@quinn
Copy link
Copy Markdown
Contributor Author

quinn commented Oct 4, 2016

@lgebhardt pushed. I'll squash these when it's ready.

@lgebhardt
Copy link
Copy Markdown
Contributor

Thanks. Looks ready to squash to me.

 * remove 'rails/all' from test helper
 * add activerecord and railties to gemspec
@quinn
Copy link
Copy Markdown
Contributor Author

quinn commented Oct 4, 2016

@lgebhardt ok cool, done.

@lgebhardt lgebhardt merged commit 5a04e6b into JSONAPI-Resources:master Oct 7, 2016
@lgebhardt
Copy link
Copy Markdown
Contributor

@quinn Thanks!

@evolve2k
Copy link
Copy Markdown

evolve2k commented Oct 7, 2016

Nice work folks :)

@konk303
Copy link
Copy Markdown

konk303 commented Feb 15, 2017

why updated dependency of activerecord/railties to 4.1 instead of 4.0 ? 😢
any particular reason?

I am using rails4.0 and noticed I couldn't update to 0.9.0.

using unsupported old rails is absolutely my bad I understand,
want to know if there is stg actually doesn't work with rails4.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants