Skip to content

Add configuration option to whitelist all exceptions.#888

Merged
lgebhardt merged 3 commits intoJSONAPI-Resources:masterfrom
Petesta:whitelist-all-exceptions
Oct 28, 2016
Merged

Add configuration option to whitelist all exceptions.#888
lgebhardt merged 3 commits intoJSONAPI-Resources:masterfrom
Petesta:whitelist-all-exceptions

Conversation

@Petesta
Copy link
Copy Markdown
Contributor

@Petesta Petesta commented Oct 25, 2016

No description provided.

@Petesta
Copy link
Copy Markdown
Contributor Author

Petesta commented Oct 25, 2016

This PR addresses this issue.

@Petesta
Copy link
Copy Markdown
Contributor Author

Petesta commented Oct 25, 2016

@lgebhardt

Comment thread lib/jsonapi/configuration.rb Outdated
# the `Pundit::NotAuthorizedError` to the `exception_class_whitelist`.
self.exception_class_whitelist = []


Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor nit, but could you remove this extra line?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ahh, yes!

@lgebhardt lgebhardt merged commit d35f2e5 into JSONAPI-Resources:master Oct 28, 2016
@lgebhardt
Copy link
Copy Markdown
Contributor

@Petesta Thanks!

@Petesta Petesta deleted the whitelist-all-exceptions branch October 28, 2016 13:43
@Petesta
Copy link
Copy Markdown
Contributor Author

Petesta commented Oct 28, 2016

Is there a plan to publish version 0.9.0.pre to rubygems.org or point to master branch on Github?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants