Allow includes to follow namespacing#904
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom Nov 16, 2016
Merged
Conversation
Contributor
|
@nagirrab Thanks! The original intent was to have namespaces used for versioning, so it's not a surprise that you've had some issues mixing resources across namespaces. In the cases fully supported by JR the namespace of the @resource_klass and resource_klass should be the same. It's not going to be simple to get mixed namespaces fully supported, but it seems there is demand for it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor bug fix: there was a bug where if you do an
includeacross a namespace boundary, e.g. in the case of:An includes request of
?includes=intermediate.childwould bomb out because it was usingBaseResourcerather thanNamespaced::IntermediateResourcefor looking upChildResource. This fixes that specific issue.Not sure what your intentions with regards to namespaced resources are in general - I've had to put a few hacks in place to make things work in general, but this particular bug fix seems like it should go in right away.