Fix issue where resources received context nested in hash#905
Merged
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom Nov 16, 2016
austenito:fix-context-for-cached-resources
Merged
Fix issue where resources received context nested in hash#905lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom austenito:fix-context-for-cached-resources
lgebhardt merged 1 commit intoJSONAPI-Resources:masterfrom
austenito:fix-context-for-cached-resources
Conversation
* If caching has been enabled, however disabled for a resource, the
context values are nested in a a 'context' key. For example:
{ context: { foo: :bar } } vs { foo: :bar }
Contributor
|
@austenito Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I wasn't sure how to test, so I ended up adding context to a resource. I'm open to suggestions on how you wanted this case covered.