Public model_name_for_type method#924
Merged
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom Dec 8, 2016
Merged
Conversation
Contributor
|
@Exelord Looking at it a little closer the method should probably be a class method and moved down to the class << self
#...
def model_name_for_type(type)
type_class_name = type.to_s.classify
resource = resource_for(type_class_name)
resource ? resource._model_name.to_s : type_class_name
end
end |
Contributor
Author
|
@lgebhardt You are right! I just forgot about moving it to If u have more ideas or comment, go on! Thanks :) |
Contributor
|
@Exelord Thanks! |
|
How can this new feature be used? Trying to see if it's something that can temporarily be used for #927 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I just think this method could be used in many cases associated with polymorphic relations like filtering by polymorphic model type. In that case having this public could make it easier to implement.