Rename local variable include#944
Merged
lgebhardt merged 3 commits intoJSONAPI-Resources:masterfrom Dec 23, 2016
Merged
Conversation
- this avoids collision with a keyword, which can be confusing
lgebhardt
reviewed
Dec 23, 2016
|
|
||
| def parse_include_directives(include) | ||
| return if include.nil? | ||
| def parse_include_directives(include_directives) |
Contributor
There was a problem hiding this comment.
The name include_directives might be confused with the parsed @include_directives. Maybe rename to raw_include, include_param or something similar.
Contributor
Author
There was a problem hiding this comment.
Thanks, will edit right now.
Contributor
Author
|
@lgebhardt There. The |
Contributor
Author
|
I also note that we'd be better off doing
|
Contributor
|
@olleolleolle Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR renames a local variable in one of the methods concerning
includes, the JSONAPI concept.This avoids collision with the Ruby keyword, which can be confusing for the reader.
(Also: use
#mapto create a list.)(I came to read #937 and was a little confused, at first.)