Fix has_one polymorphism#945
Merged
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom Dec 29, 2016
Merged
Conversation
Contributor
|
@nagirrab Thanks for the fix. Could you add a test that demonstrates the issue and confirms the fix? |
Contributor
Author
|
@lgebhardt done. The test case is a little wonky because has_one polymorphism through other relations is actually not trivial to get working, but hopefully it illustrates the point. |
Contributor
|
@nagirrab Thanks! |
lgebhardt
pushed a commit
that referenced
this pull request
Jan 17, 2017
* Fix has_one polymorphism * Add tests for has one polymorphic serialization (cherry picked from commit 9ad4d91)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem:
has_onerelationships that are polymorphic do not work as expected: instead of getting the actual polymorphic resource, you get instead the base class.Fix: extend the handling used in the polymorphic
belongs_torelationship to cover thehas_onecase as well. I used the exact same code as the block above.Tested on Rails 4.2.x.
Let me know if you have any questions or concerns.