Verify filters that are passed to show_related_resources#971
Merged
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom Feb 23, 2017
Merged
Verify filters that are passed to show_related_resources#971lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom
lgebhardt merged 2 commits intoJSONAPI-Resources:masterfrom
Conversation
Contributor
|
@hidde-jan Thanks! |
lgebhardt
pushed a commit
to lgebhardt/jsonapi-resources
that referenced
this pull request
Feb 24, 2017
…ources#971) (cherry picked from commit 2480458)
lgebhardt
pushed a commit
that referenced
this pull request
Feb 24, 2017
(cherry picked from commit 2480458)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #964
I've also removed the
source_klass.verify_filterssince the source resource shouldn't really know about the filters from another resource.