Skip to content

Store exceptions in request env #994

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgebhardt merged 1 commit into from
Mar 21, 2017
Merged

Store exceptions in request env #994

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions lib/jsonapi/acts_as_resource_controller.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -284,6 +284,9 @@ def handle_exceptions(e)
}
end

# Store exception for other middlewares
request.env['action_dispatch.exception'] ||= e

internal_server_error = JSONAPI::Exceptions::InternalServerError.new(e)
Rails.logger.error { "Internal Server Error: #{e.message} #{e.backtrace.join("\n")}" }
errors = internal_server_error.errors
Expand Down
15 changes: 15 additions & 0 deletions test/controllers/controller_test.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,21 @@ def test_whitelist_all_exceptions
JSONAPI.configuration.whitelist_all_exceptions = original_config
end

def test_exception_added_to_request_env
original_config = JSONAPI.configuration.whitelist_all_exceptions
$PostProcessorRaisesErrors = true
refute @request.env['action_dispatch.exception']
assert_cacheable_get :index
assert @request.env['action_dispatch.exception']

JSONAPI.configuration.whitelist_all_exceptions = true
assert_cacheable_get :index
assert @request.env['action_dispatch.exception']
ensure
$PostProcessorRaisesErrors = false
JSONAPI.configuration.whitelist_all_exceptions = original_config
end

def test_exception_includes_backtrace_when_enabled
original_config = JSONAPI.configuration.include_backtraces_in_errors
$PostProcessorRaisesErrors = true
Expand Down