Skip to content

feat(signals): classify Elixir, Swift, and Gradle lockfiles#1885

Merged
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/signals-extra-lockfiles
Jun 30, 2026
Merged

feat(signals): classify Elixir, Swift, and Gradle lockfiles#1885
JSONbored merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/signals-extra-lockfiles

Conversation

@kiannidev

@kiannidev kiannidev commented Jun 30, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Recognize mix.lock, Package.resolved, and gradle.lockfile as dependency lockfiles in slop path matchers

Test plan

  • npx vitest run test/unit/path-matchers.test.ts

Recognize mix.lock, Package.resolved, and gradle.lockfile as dependency
lockfiles so slop classifiers do not count them as substantive source work.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev kiannidev requested a review from JSONbored as a code owner June 30, 2026 18:13
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jun 30, 2026
@gittensory-orb

gittensory-orb Bot commented Jun 30, 2026

Copy link
Copy Markdown

Tip

🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩🟩

✅ Gittensory review result - approve/merge recommended

Review updated: 2026-06-30 20:18:44 UTC

2 files · 1 AI reviewer · no blockers · readiness 66/100 · CI green · unknown

✅ Suggested Action - Approve/Merge

  • safe to merge

Review summary
This change extends the lockfile basename set with Elixir, SwiftPM, and Gradle lockfiles and adds direct `isLockfile` coverage for each. The implementation is consistent with the existing matcher design because paths are normalized to lowercase before basename lookup, so the `Package.resolved` test is covered by the lowercase set entry. The visible diff is small, coherent, and safe to proceed.

Nits — 2 non-blocking
  • Consider adding representative `classifyChangedFile` cases in `test/unit/path-matchers.test.ts` for `mix.lock`, `Package.resolved`, and `gradle.lockfile` so the public classifier path stays explicitly covered, not only the helper matcher.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (size label size:XS; no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR; address the blocker before review.
Contributor workload ✅ 10/10 Author activity: 3157 registered-repo PR(s), 1811 merged, 51 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 3157 PR(s), 51 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 3157 PR(s), 51 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Explain no-issue PR.
  • Fix the blocker.
  • Triage stale or unlinked PRs.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot added gittensor Gittensor contributor context gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier. labels Jun 30, 2026
@JSONbored JSONbored added gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier. and removed gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier. labels Jun 30, 2026
@dosubot dosubot Bot added the lgtm Approved by a maintainer. label Jun 30, 2026
@JSONbored JSONbored merged commit 86cf47d into JSONbored:main Jun 30, 2026
7 checks passed
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jun 30, 2026
@gittensory-orb gittensory-orb Bot added gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier. and removed gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier. labels Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier. gittensor Gittensor contributor context lgtm Approved by a maintainer. size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants