Skip to content

fix(selfhost): import withOtelSpan in the durable queues (main typecheck broken)#1996

Merged
JSONbored merged 1 commit into
mainfrom
claude/fix-queue-otel-import
Jul 1, 2026
Merged

fix(selfhost): import withOtelSpan in the durable queues (main typecheck broken)#1996
JSONbored merged 1 commit into
mainfrom
claude/fix-queue-otel-import

Conversation

@JSONbored

Copy link
Copy Markdown
Owner

Summary

main currently fails npm run typecheck: src/selfhost/pg-queue.ts:345 and src/selfhost/sqlite-queue.ts:288 call withOtelSpan(...) for the *.queue.admission_deferred span (exactly as src/server.ts:689 does) but import only withReviewSpan from ./tracingwithOtelSpan is never imported.

#1922 (sampled Sentry spans) added those calls and #1986 (Postgres tooling) merged right behind it; each was green on its own branch, but together on main the import is missing → error TS2304: Cannot find name 'withOtelSpan'. This blocks CI on every open PR.

Fix: add import { withOtelSpan } from "./otel"; to both durable-queue files. Behavior-preserving — the span was already intended (it mirrors the existing withReviewSpan call a few lines down and server.ts's usage).

Validation

  • npm run typecheck (fails on main without this; passes with it)
  • git diff --check
  • npx vitest run test/unit/selfhost-pg-queue.test.ts test/unit/selfhost-sqlite-queue.test.ts — 95 pass
  • No new tests: this is a missing-import compile fix; the span call sites are already covered by the queue tests.

pg-queue.ts and sqlite-queue.ts call withOtelSpan for the admission-deferred
span (like server.ts does) but import only withReviewSpan, so tsc fails with
'Cannot find name withOtelSpan' on main — #1922 added the calls and #1986 landed
close behind, green separately but broken together. Add the missing import from
./otel. Behavior-preserving (the span was already intended); unblocks CI.
@dosubot dosubot Bot added the size:XS This PR changes 0-9 lines, ignoring generated files. label Jul 1, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 1, 2026

Copy link
Copy Markdown

Important

🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪

🔍 Gittensory is reviewing…

AI analysis is in progress. This comment will update when the review is complete.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing

@JSONbored JSONbored self-assigned this Jul 1, 2026
@JSONbored JSONbored merged commit 1ac3ff3 into main Jul 1, 2026
10 checks passed
@JSONbored JSONbored deleted the claude/fix-queue-otel-import branch July 1, 2026 06:31
@github-project-automation github-project-automation Bot moved this from Todo to Done in gittensory - v1 roadmap Jul 1, 2026
@codecov

codecov Bot commented Jul 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@514ff75). Learn more about missing BASE report.
⚠️ Report is 2 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1996   +/-   ##
=======================================
  Coverage        ?   95.63%           
=======================================
  Files           ?      220           
  Lines           ?    24395           
  Branches        ?     8846           
=======================================
  Hits            ?    23331           
  Misses          ?      436           
  Partials        ?      628           
Files with missing lines Coverage Δ
src/selfhost/sqlite-queue.ts 99.19% <ø> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

No open projects
Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant