Skip to content

test(signals): extend repo-policy-compiler branch coverage#3432

Merged
gittensory-orb[bot] merged 2 commits into
JSONbored:mainfrom
bohdansolovie:test/repo-policy-compiler-coverage-2102
Jul 5, 2026
Merged

test(signals): extend repo-policy-compiler branch coverage#3432
gittensory-orb[bot] merged 2 commits into
JSONbored:mainfrom
bohdansolovie:test/repo-policy-compiler-coverage-2102

Conversation

@bohdansolovie

Copy link
Copy Markdown
Contributor

Fixes #2102

Summary

Extends test/unit/repo-policy-compiler.test.ts to cover remaining branches in compileRepoPolicyCompilerOutput:

  • Preferred direct-PR and issue-discovery lane summaries/titles
  • Issue-discovery lane inheriting direct-PR preferred paths
  • Issue-discovery publicNotes filtering lines containing "direct"
  • Default generatedAt when omitted + deterministic output for identical fixed inputs
  • Label policy field shape and public-safe filtering of preferred labels

Test plan

  • CI validate-code (vitest suite includes repo-policy-compiler.test.ts)

Made with Cursor

bohdansolovie and others added 2 commits July 5, 2026 08:44
…#2102)

Cover preferred lane summaries, path inheritance, direct-note filtering, generatedAt default, and label policy shape.

Co-authored-by: Cursor <cursoragent@cursor.com>
…bored#2102)

Assert direct-tagged notes are excluded while other entry guidance remains on the issue-discovery lane.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bohdansolovie bohdansolovie requested a review from JSONbored as a code owner July 5, 2026 06:54
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier. label Jul 5, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 06:59:33 UTC

1 file · 1 AI reviewer · no blockers · readiness 80/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This PR only extends the repo-policy compiler unit tests, and the added cases exercise concrete output fields for lane preference, note filtering, generated timestamp fallback, determinism, and label policy shape. The assertions are tied to the public compiler API rather than mocked internals, so the coverage additions are useful and low-risk. CI has already validated the suite on this commit.

Nits — 2 non-blocking
  • test/unit/repo-policy-compiler.test.ts:139 could also assert the issue-discovery notes preserve the allowed custom note count/order if that contract matters, since the current arrayContaining checks allow extra unexpected notes.
  • test/unit/repo-policy-compiler.test.ts:158 could make the generatedAt fallback assertion stricter with a full ISO timestamp regex if the compiler contract promises ISO-8601 output.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ✅ Linked #2102
Related work ✅ No active overlap found No same-issue or scoped active PR overlap found.
Change scope ✅ 20/20 Low review scope from cached public metadata (1 linked issue).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 267 registered-repo PR(s), 167 merged, 9 issue(s).
Contributor context ✅ Confirmed Gittensor contributor bohdansolovie; Gittensor profile; 267 PR(s), 9 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: bohdansolovie
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 267 PR(s), 9 issue(s).
  • PR-specific overlap: none found.
Contributor next steps
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.46%. Comparing base (abe34a7) to head (0e95602).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3432   +/-   ##
=======================================
  Coverage   93.46%   93.46%           
=======================================
  Files         291      291           
  Lines       30790    30790           
  Branches    11221    11221           
=======================================
  Hits        28779    28779           
  Misses       1355     1355           
  Partials      656      656           
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit 5bf0a77 into JSONbored:main Jul 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

test(signals): full-branch coverage for repo-policy-compiler compileRepoPolicyCompilerOutput

1 participant