Skip to content

test(config): harden gate.readiness.minScore round-trip coverage#3436

Merged
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:test/gate-readiness-minscore-roundtrip-2053
Jul 5, 2026
Merged

test(config): harden gate.readiness.minScore round-trip coverage#3436
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
bohdansolovie:test/gate-readiness-minscore-roundtrip-2053

Conversation

@bohdansolovie

Copy link
Copy Markdown
Contributor

Fixes #2053

Summary

Adds focused unit tests for gate.readiness.minScore parse/serialize behavior in focus-manifest.ts:

  • gate.present flips true when only readiness.minScore is set
  • Boundary round-trip (0, 1, 42, 99, 100) through gateConfigToJsonparseFocusManifest
  • Invalid values (string, NaN, ±Infinity) warn and null out the score
  • Omitted minScore stays absent from serialized readiness block

Test-only hardening; no production behavior change.

Test plan

  • CI validate-code (vitest suite includes focus-manifest.test.ts)

Made with Cursor

…Nbored#2053)

Cover minScore-only present flag, boundary round-trips, invalid-value warnings, and omitted serialization.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bohdansolovie bohdansolovie requested a review from JSONbored as a code owner July 5, 2026 07:03
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.47%. Comparing base (5bf0a77) to head (e18f325).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3436   +/-   ##
=======================================
  Coverage   93.47%   93.47%           
=======================================
  Files         292      292           
  Lines       30797    30797           
  Branches    11225    11225           
=======================================
+ Hits        28786    28787    +1     
  Misses       1355     1355           
+ Partials      656      655    -1     

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@gittensory-orb gittensory-orb Bot added the gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier. label Jul 5, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Important

🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪🟪

🔍 Gittensory is reviewing…

AI analysis is in progress. This comment will update when the review is complete.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed · 🟪 Reviewing

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit fe9ff1b into JSONbored:main Jul 5, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:bug Gittensor-scored bug fix — scores a 0.5x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(config): add gate.readiness.minScore round-trip test hardening

1 participant