Skip to content

feat(engine): add countPlanSteps#3439

Merged
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-count-plan-steps
Jul 5, 2026
Merged

feat(engine): add countPlanSteps#3439
gittensory-orb[bot] merged 1 commit into
JSONbored:mainfrom
kiannidev:feat/engine-count-plan-steps

Conversation

@kiannidev

Copy link
Copy Markdown
Contributor

Summary

  • Add countPlanSteps in @jsonbored/gittensory-engine — returns the total number of steps in a plan DAG.
  • Pure helper alongside countPlanStepsByStatus for miner and dashboard progress summaries.
  • Vitest coverage at 100% patch on the new helper.

Test plan

  • COVERAGE_NO_THRESHOLDS=1 npx vitest run test/unit/plan-step-count.test.ts --coverage
  • npx diff-cover coverage/lcov.info --compare-branch=main --fail-under=99 → 100%
  • npm run build --workspace @jsonbored/gittensory-engine && npm run build:miner

Made with Cursor

Expose a pure plan-DAG step total for miner and dashboard progress summaries.

Co-authored-by: Cursor <cursoragent@cursor.com>
@kiannidev kiannidev requested a review from JSONbored as a code owner July 5, 2026 07:09
@superagent-security

Copy link
Copy Markdown

Superagent didn't find any vulnerabilities or security issues in this PR.

@gittensory-orb gittensory-orb Bot added the gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier. label Jul 5, 2026
@gittensory-orb

gittensory-orb Bot commented Jul 5, 2026

Copy link
Copy Markdown

Warning

🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨🟨

⏸️ Gittensory review result - manual review recommended

Review updated: 2026-07-05 07:15:19 UTC

3 files · 1 AI reviewer · no blockers · readiness 55/100 · CI green · clean

⏸️ Suggested Action - Manual Review

Review summary
This adds a pure countPlanSteps helper, exports it from the engine barrel, and covers the direct and barrel import paths. The implementation is the right layer for a PlanDag total because it reads the already-normalized steps array and has no status-dependent behavior. I do not see a reachable correctness issue in the visible diff.

Nits — 3 non-blocking
  • nit: packages/gittensory-engine/src/plan-step-count.ts:1 is a separate module for a one-line sibling of countPlanStepsByStatus; consider colocating it with plan-step-stats.ts if you want the plan counting API in one place.
  • packages/gittensory-engine/src/plan-step-count.ts:6 could be moved next to countPlanStepsByStatus in plan-step-stats.ts to reduce tiny-module sprawl, unless you intentionally want one helper per file.
  • Readiness score is below the configured threshold — Use the readiness panel as advisory maintainer context; the score does not block this PR.
Signal Result Evidence
Code review ✅ No blockers 1 reviewer
Linked issue ⚠️ Missing No linked issue or no-issue rationale found.
Related work ⚠️ 3 scoped overlaps Top overlaps are listed below; lower-confidence bulk is hidden.
Change scope ❌ 8/20 High review scope from cached public metadata (no linked issue context).
Validation posture ❌ 5/25 Preflight is holding this PR: the review lane is unavailable, so it is not ready for automated review.
Contributor workload ✅ 10/10 Author activity: 1362 registered-repo PR(s), 668 merged, 49 issue(s).
Contributor context ✅ Confirmed Gittensor contributor kiannidev; Gittensor profile; 1362 PR(s), 49 issue(s).
Gate result ✅ Passing No configured blocker found.
Review context
  • Author: kiannidev
  • Role context: outside_contributor
  • Public audience mode: oss maintainer
  • Lane context: Repository registration is not available in the local Gittensory cache.
  • Public profile languages: not available
  • Official Gittensor activity: 1362 PR(s), 49 issue(s).
  • Related work: Titles/paths share 9 meaningful terms. (issue #2038, issue #2059)
  • Related work: Titles/paths share 10 meaningful terms. (issue #2038, issue #2040)
  • Related work: Titles/paths share 10 meaningful terms. (issue #2059, issue #2063)
  • Additional title-only matches omitted; title-only overlap does not block.
Contributor next steps
  • Explain no-issue PR.
  • Review top overlaps.
  • Add a concise scope and risk note.
  • Await review-lane availability.
  • Refresh registry data or choose a registered active repo.
  • Link the issue being solved, or explicitly explain why this is a no-issue PR.
  • Check active issues and PRs before submitting.
Signal definitions
  • Related work = same linked issue, overlapping active PRs, or title/path similarity.
  • Change scope = cached public metadata such as size labels, draft state, and review-burden hints.
  • Validation posture = whether the PR provides enough public validation/test evidence for maintainer review.
  • Contributor workload = public contributor activity and cleanup pressure, not a repo-wide quality failure.
  • Contributor context = public GitHub/Gittensor identity context; non-Gittensor status is not a blocker.

🟩 Safe / merged · 🟦 Advisory · 🟨 Held for review · 🟥 Blocked / closed


💰 Earn for open-source contributions like this. Gittensor lets GitHub contributors earn for the work they already do — register to start earning →.

Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers.

  • Re-run Gittensory review

@gittensory-orb gittensory-orb Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gittensory approves — the gate is satisfied and CI is green.

@gittensory-orb gittensory-orb Bot merged commit f6b9872 into JSONbored:main Jul 5, 2026
7 checks passed
@codecov

codecov Bot commented Jul 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.99%. Comparing base (4af45df) to head (dde93d5).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3439   +/-   ##
=======================================
  Coverage   92.99%   92.99%           
=======================================
  Files         294      295    +1     
  Lines       30961    30962    +1     
  Branches    11290    11290           
=======================================
+ Hits        28791    28792    +1     
  Misses       1514     1514           
  Partials      656      656           
Files with missing lines Coverage Δ
packages/gittensory-engine/src/plan-step-count.ts 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gittensor:feature Gittensor-scored feature linked to a feature issue — scores a 1.25x multiplier.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant