feat(config): add Gittensory repo focus manifest#389
Open
kiannidev wants to merge 3 commits into
Open
Conversation
JSONbored
requested changes
Jun 5, 2026
Owner
JSONbored
left a comment
There was a problem hiding this comment.
@kiannidev the manifest/parser/API shape is useful, but I cannot merge this policy as written.
A few notes:
- The main blocker is
.gittensory.ymltreatingapps/gittensory-ui/as a blocked path. - That would classify legitimate focused control-panel work as blocked, which conflicts with how this repo currently accepts UI work tied to operator analytics, safety, and release workflows.
- The API/OpenAPI direction is fine, but the policy semantics need to match the repo.
Required changes:
- Rework the focus manifest so UI work is discouraged/conditional where appropriate, not categorically blocked.
- Update tests to cover allowed focused UI changes and genuinely blocked surfaces separately.
- Keep the manifest language aligned with CONTRIBUTING instead of creating a stricter hidden policy.
Validation expected:
- Rerun the focused manifest/parser/API tests and any OpenAPI check touched by this PR.
|
Important Gittensory found maintainer review notesScoped related-work signals were found for this PR. They are advisory unless the gate reports a blocker. Readiness score: 75/100
Signal definitions
Review context
Maintainer notes
Contributor next steps
Checked by Gittensory, a quiet PR intelligence layer for OSS maintainers. Learn more about Gittensor contribution workflows. |
2c90386 to
a094551
Compare
Add .gittensory.yml with wanted/blocked paths aligned to CONTRIBUTING: apps/gittensory-ui is wanted for focused control-panel work; site/, CNAME, and lovable paths stay blocked. Support YAML parsing, bundled self-repo fallback, maintainer GET/PUT focus-manifest routes, and regression tests.
a094551 to
6aa08d0
Compare
Contributor
Author
|
@JSONbored Thanks for the review — reworked the manifest policy and merged latest Policy changes
Tests
Merge
Ready for another look. |
Add targeted regression tests for configured self-repo resolution, focus-manifest route refresh/PUT fallbacks, loader persistence edges, and non-mapping JSON manifest content. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #118
Summary
.gittensory.yml(wanted backend/MCP paths, blocked website/lovable areas, test expectations, public vs private notes)..gittensory.ymlfirst, then JSON candidates) with safe malformed-manifest warnings.src/config/gittensory-repo-focus-manifest.ts) so decision packs, preflight, and maintainer APIs work before the file is onmain.GET/PUT/v1/repos/{owner}/{repo}/focus-manifestreturning manifest + compiled policy.Scope
CONTRIBUTING.mdand does not reintroduce GitHub Pages, VitePress,site/, orCNAME.Validation
git diff --checknpm run actionlintnpm run typechecknpm run test:coveragelocally; global coverage stays at or above 97% for lines, statements, functions, and branches (aim for 98%+ branch coverage locally so CI variance does not fail near the threshold)npm run test:workersnpm run build:mcpnpm run test:mcp-packnpm run ui:openapi:checknpm run ui:lintnpm run ui:typechecknpm run ui:buildnpm audit --audit-level=moderateIf any required check was skipped, explain why:
New / updated tests:
test/unit/gittensory-focus-manifest.test.ts,test/unit/focus-manifest.test.ts,test/unit/focus-manifest-loader.test.ts.Safety
Notes
GITTENSORY_DRIFT_ISSUE_REPOwhen set; otherwiseJSONbored/gittensory.GITTENSORY_REPO_FOCUS_MANIFEST_YAMLmust stay in sync with.gittensory.yml(enforced by unit test).