Skip to content

refactor(fleet): use shared derived repo validation#52

Merged
JSONbored merged 2 commits into
mainfrom
codex/fleet-derived-validator-shims
Apr 30, 2026
Merged

refactor(fleet): use shared derived repo validation#52
JSONbored merged 2 commits into
mainfrom
codex/fleet-derived-validator-shims

Conversation

@JSONbored
Copy link
Copy Markdown
Owner

Summary

  • Replaces the copied derived-repo validation logic with the shared aio-fleet shim
  • Bumps reusable AIO workflow callers to aio-fleet@6cb527a4cccd624ad73447b6b73cda9b56b4c9c7

What changed

  • scripts/validate-derived-repo.sh now delegates to aio-fleet validate-derived
  • Generated workflow callers now reference the fleet SHA that contains the centralized validator

Why

  • Keeps derived-repo validation behavior centralized in aio-fleet
  • Reduces duplicated validator logic across the active AIO fleet while preserving the existing script entrypoint

Validation

  • python3 scripts/validate-template.py --all
  • bash scripts/validate-derived-repo.sh .
  • git diff --check
  • actionlint -shellcheck '' -pyflakes '' -ignore 'SC2129' .github/workflows/*.yml
  • python -m aio_fleet verify-caller --repo simplelogin-aio --repo-path /Users/shadowbook/Documents/simplelogin-aio --ref 6cb527a4cccd624ad73447b6b73cda9b56b4c9c7

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: cb160ba1f2

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +12 to 14
if python3 -c "import aio_fleet" >/dev/null 2>&1; then
exec python3 -m aio_fleet.cli "${args[@]}"
fi
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Keep derived-repo validator runnable without extra checkout

This change makes scripts/validate-derived-repo.sh hard-depend on an external aio_fleet module/checkout, but this repository does not vendor or declare that dependency, so a normal clone now fails validation (template validation error: aio-fleet is required...) instead of running the checks. That breaks existing in-repo usage, including tests/template/test_validate_derived_repo.py, which invokes this script directly and now exits non-zero unless contributors manually install or co-locate aio-fleet first.

Useful? React with 👍 / 👎.

@JSONbored JSONbored merged commit 8ee9a06 into main Apr 30, 2026
14 checks passed
@JSONbored JSONbored deleted the codex/fleet-derived-validator-shims branch April 30, 2026 19:17
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: acd1f5943d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +12 to +13
if python3 -c "import aio_fleet" >/dev/null 2>&1; then
exec python3 -m aio_fleet.cli "${args[@]}"
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Validate aio_fleet CLI before bypassing local checkout

The new import gate executes python3 -m aio_fleet.cli as soon as import aio_fleet succeeds, which means any stale or incompatible site-package version of aio_fleet will be used and the script will never try AIO_FLEET_PATH or sibling checkout fallbacks. In environments that already have an older aio_fleet installed (missing validate-derived or a different CLI layout), this causes immediate failure even when a valid local checkout is available.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant