refactor(fleet): use shared derived repo validation#52
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: cb160ba1f2
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if python3 -c "import aio_fleet" >/dev/null 2>&1; then | ||
| exec python3 -m aio_fleet.cli "${args[@]}" | ||
| fi |
There was a problem hiding this comment.
Keep derived-repo validator runnable without extra checkout
This change makes scripts/validate-derived-repo.sh hard-depend on an external aio_fleet module/checkout, but this repository does not vendor or declare that dependency, so a normal clone now fails validation (template validation error: aio-fleet is required...) instead of running the checks. That breaks existing in-repo usage, including tests/template/test_validate_derived_repo.py, which invokes this script directly and now exits non-zero unless contributors manually install or co-locate aio-fleet first.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: acd1f5943d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if python3 -c "import aio_fleet" >/dev/null 2>&1; then | ||
| exec python3 -m aio_fleet.cli "${args[@]}" |
There was a problem hiding this comment.
Validate aio_fleet CLI before bypassing local checkout
The new import gate executes python3 -m aio_fleet.cli as soon as import aio_fleet succeeds, which means any stale or incompatible site-package version of aio_fleet will be used and the script will never try AIO_FLEET_PATH or sibling checkout fallbacks. In environments that already have an older aio_fleet installed (missing validate-derived or a different CLI layout), this causes immediate failure even when a valid local checkout is available.
Useful? React with 👍 / 👎.
Summary
aio-fleetshimaio-fleet@6cb527a4cccd624ad73447b6b73cda9b56b4c9c7What changed
scripts/validate-derived-repo.shnow delegates toaio-fleet validate-derivedWhy
aio-fleetValidation
python3 scripts/validate-template.py --allbash scripts/validate-derived-repo.sh .git diff --checkactionlint -shellcheck '' -pyflakes '' -ignore 'SC2129' .github/workflows/*.ymlpython -m aio_fleet verify-caller --repo simplelogin-aio --repo-path /Users/shadowbook/Documents/simplelogin-aio --ref 6cb527a4cccd624ad73447b6b73cda9b56b4c9c7