refactor(fleet): use shared release helper shim#54
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ffaff1ef2a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| def test_shared_release_shim_loads() -> None: | ||
| result = subprocess.run( # nosec B603 | ||
| [sys.executable, "scripts/release.py", "has-unreleased-changes"], |
There was a problem hiding this comment.
This test now hard-requires an aio_fleet checkout to exist at ../aio-fleet or .aio-fleet, but it never provisions that dependency or skips when unavailable. In a normal standalone clone of this repo, scripts/release.py exits with the aio_fleet.release is required error, so this unit test fails deterministically and makes the suite non-hermetic. Please either inject a temporary stub path/module for the test or gate it behind an explicit availability check.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b7ff0ddd0d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| capture_output=True, | ||
| ) | ||
|
|
||
| assert result.returncode == 0, result.stderr # nosec B101 |
There was a problem hiding this comment.
This test unconditionally executes scripts/release.py and expects exit code 0, but the shim now exits with aio_fleet.release is required unless either .aio-fleet/src or ../aio-fleet/src exists. In a normal standalone clone (no sibling aio-fleet checkout), pytest tests/unit/test_release_shim.py fails deterministically, so the unit suite is non-hermetic and will break environments that run repo-local tests without that external workspace layout.
Useful? React with 👍 / 👎.
1 participant
Summary
What changed
scripts/release.pynow delegates toaio_fleet.release.aio-fleetfor release helper usageWhy
Validation
python3 scripts/release.py next-versionpython -m aio_fleet validate --allpython -m aio_fleet sync-workflows --dry-run --ref 3b8613bf305a8bbebfe9f61636db935c303fe2cdpython -m aio_fleet sync-boilerplate --dry-runpython -m aio_fleet debt-report --catalog-path /Users/shadowbook/.codex/worktrees/7c71/awesome-unraid --format textpython -m aio_fleet trunk-auditgit diff --checkNotes