fix(ci): gate Docker Hub login without direct secrets expressions#47
Merged
fix(ci): gate Docker Hub login without direct secrets expressions#47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes GitHub Actions startup failures caused by invalid direct
secrets.*expressions in workflow conditions and restores Docker Hub publish gating.What changed
Resolve Docker Hub publish settingsstep inCI / Sure-AIOpublish jobenabled(true/false based on Docker Hub secret presence)image_name(fromDOCKERHUB_IMAGE_NAME, fallback toIMAGE_NAME)if: ${{ secrets... }}usageif: ${{ steps.dockerhub.outputs.enabled == 'true' }}Why
mainworkflows failed to parse with:Unrecognized named-value: 'secrets'Validation
python3 scripts/validate-template.pyNotes
DOCKERHUB_USERNAMEandDOCKERHUB_TOKENare configured.DOCKERHUB_IMAGE_NAMEremains supported for namespace override (defaults tojsonbored/sure-aioviaIMAGE_NAMEfallback).