Skip to content

[fix] Enable qualified table name for DROP INDEX command #2344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −2
Open

[fix] Enable qualified table name for DROP INDEX command #2344

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions src/main/jjtree/net/sf/jsqlparser/parser/JSqlParserCC.jjt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8782,8 +8782,15 @@ Drop Drop():

name = Table() { drop.setName(name); }
[ LOOKAHEAD(2) funcArgs = FuncArgsList() ]
((tk=<S_IDENTIFIER> | tk=<K_CASCADE> | tk=<K_RESTRICT> | tk=<K_ON>) { dropArgs.add(tk.image); })*

(
(
tk=<S_IDENTIFIER> | tk=<K_CASCADE> | tk=<K_RESTRICT>
) { dropArgs.add(tk.image); }
|
(
<K_ON> name = Table() { dropArgs.add("ON"); dropArgs.add(name.toString()); }
)
)*
{
if (dropArgs.size() > 0) {
drop.setParameters(dropArgs);
Expand Down
10 changes: 10 additions & 0 deletions src/test/java/net/sf/jsqlparser/statement/drop/DropTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,16 @@ public void testDropIndexOnTable() throws JSQLParserException {
assertSqlCanBeParsedAndDeparsed("DROP INDEX idx ON abc");
}

@Test
public void testDropIndexOnQualifiedTable() throws JSQLParserException {
assertSqlCanBeParsedAndDeparsed("DROP INDEX idx ON qual.tbl");
}

@Test
public void testDropIndexOnDoubleQualifiedTable() throws JSQLParserException {
assertSqlCanBeParsedAndDeparsed("DROP INDEX idx ON dbl.qual.tbl");
}

@Test
public void testDrop2() throws JSQLParserException {
Drop drop = (Drop) parserManager.parse(new StringReader("DROP TABLE \"testtable\""));
Expand Down