Migration from Lit 2.8 to 3.2#183
Conversation
|
@Abasz are you able to rebase the code in order to resolve the merge conflicts (otherwise I'll do it manually)? |
Update lit dependency to version 3.2.0 and adjust config and build tools to support the new version. Migrate code with the minimal required changes.
|
Did a rebase and a force push to retain commit history. Note that CI fails because of the invalid config option added in your commit "Allow Console messages on the client". |
|
This is ready for testing. |
| [ | ||
| "@babel/plugin-proposal-decorators", | ||
| { | ||
| "version": "2023-05" |
There was a problem hiding this comment.
Did you test bundle size with standard decorators vs experimental? The guide warns about significant size increases.
While Lit 3 adds support for standard decorators, we still recommend that TypeScript users stay with experimental decorators. This is because the emitted code for standard decorators from the TypeScript and Babel compilers is quite large at the moment.
https://lit.dev/docs/releases/upgrade/#standard-decorator-migration
Though. I get that things might have changed since the migration guide was written :)
There was a problem hiding this comment.
Aaah no I have not actually. To be fair I was thinking that this will solve it self when we move to TS and Vite :)
| this._dialog = html` | ||
| <app-dialog @close=${(event) => { | ||
| this._dialog = undefined | ||
| // this._dialog = undefined |
There was a problem hiding this comment.
Why was this commented instead of removed? If for testing, did it work?
There was a problem hiding this comment.
I was testing whether it works without this and to me it did so I did not understand the purpose any more. but I did not delete so if issues emerge I can remember to put it back :D should have added a TODO comment!
3 participants
No description provided.