refactor org.jabref.gui.journals.UndoableAbbreviator#abbreviate#12101
Closed
tina9452 wants to merge 2 commits intoJabRef:mainfrom
Closed
refactor org.jabref.gui.journals.UndoableAbbreviator#abbreviate#12101tina9452 wants to merge 2 commits intoJabRef:mainfrom
tina9452 wants to merge 2 commits intoJabRef:mainfrom
Conversation
koppor
reviewed
Oct 27, 2024
| return false; | ||
| } | ||
|
|
||
| // Store full name into fjournal but only if it exists |
Member
There was a problem hiding this comment.
Do not remove comments adding value
Contributor
There was a problem hiding this comment.
Your code currently does not meet JabRef's code guidelines.
We use Checkstyle to identify issues.
The tool reviewdog already placed comments on GitHub to indicate the places. See the tab "Files" in you PR.
Please carefully follow the setup guide for the codestyle.
Afterwards, please run checkstyle locally and fix the issues.
You can check review dog's comments at the tab "Files changed" of your pull request.
7 tasks
Member
|
Closing this issue due to inactivity 💤 Please ping us if you intend to resume work on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I refactored org.jabref.gui.journals.UndoableAbbreviator#abbreviate. This is the first step for issue #11791
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)