-
-
Notifications
You must be signed in to change notification settings - Fork 3k
Replaces the standard ComboBox with a SearchableComboBox and a free text field in custom Entry Types #14189
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Replaces the standard ComboBox with a SearchableComboBox to improve usability when adding fields. Fixes JabRef#14082
Hey @Memeel!Thank you for contributing to JabRef! Your help is truly appreciated ❤️. We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful. Please re-check our contribution guide in case of any other doubts related to our contribution workflow. |
|
Free text field is missing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No changes to project files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're right. Sorry, I accidentally removed a line in a previous commit, and the latest one reintroduces it
Replaces the single editable SearchableComboBox with two separate components: a SearchableComboBox for existing fields and a new TextField for custom fields
|
Just to make sure we are not misunderstanding the task, are we supposed to add another box below the existing one that lets you add the free text field, or should we keep a single combobox that has the searchable feature and the adding free text field? |
|
As a User I want to search for existing fields and also have the option to create a new, not yet existing one, e.g. "mycustomfield" . If this is possible with the SearchableCombobox then it's good, otherwise add a new text field where the user can enter the fieldname |
Closes #14082
This pull request replaces the standard ComboBox for adding new fields with a SearchableComboBox and a TextField in the "Custom Entry Types" preference pane.
This improves usability by allowing users to quickly filter and find a specific field when customizing entry types. The option is located under
File -> Preferences -> Entry types.Steps to test the SearchableComboBox
File -> Preferences -> Entry types.SearchableComboBox:+button.Steps to test the free text field
File -> Preferences -> Entry types.+button (second screenshot).Final result
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)