Skip to content

Conversation

@Memeel
Copy link

@Memeel Memeel commented Oct 27, 2025

Closes #14082

This pull request replaces the standard ComboBox for adding new fields with a SearchableComboBox and a TextField in the "Custom Entry Types" preference pane.

This improves usability by allowing users to quickly filter and find a specific field when customizing entry types. The option is located under File -> Preferences -> Entry types.

Steps to test the SearchableComboBox

  1. Go to File -> Preferences -> Entry types.
  2. Select any entry type from the list on the left.
  3. In the "Required and optional fields" section, look at the first dropdown menu at the bottom.
  4. Verify that this is now a SearchableComboBox:
    • Click on the dropdown. It should show the full list of available fields (first screenshot).
    • Start typing the name of a field (second screenshot).
    • Verify that the list filters dynamically to show matching fields.
  5. Select a field from the filtered list and click the + button.
  6. Verify that the field is added correctly to the list of fields for that entry type.
Capture d'écran 2025-10-28 145807 Capture d'écran 2025-10-28 145821

Steps to test the free text field

  1. Go to File -> Preferences -> Entry types.
  2. Select any entry type from the list on the left.
  3. In the "Required and optional fields" section, look at the second input box (first screenshot).
  4. Type a new custom field name and click the + button (second screenshot).
  5. Verify that the field is added correctly to the list of fields for that entry type.
Capture d'écran 2025-10-28 145839 Capture d'écran 2025-10-28 145911

Final result

Capture d'écran 2025-10-28 145920

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • I added screenshots in the PR description (if change is visible to the user)
  • I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@github-actions
Copy link
Contributor

Hey @Memeel!

Thank you for contributing to JabRef! Your help is truly appreciated ❤️.

We have automatic checks in place, based on which you will soon get automated feedback if any of them are failing. We also use TragBot with custom rules that scans your changes and provides some preliminary comments, before a maintainer takes a look. TragBot is still learning, and may not always be accurate. In the "Files changed" tab, you can go through its comments and just click on "Resolve conversation" if you are sure that it is incorrect, or comment on the conversation if you are doubtful.

Please re-check our contribution guide in case of any other doubts related to our contribution workflow.

@Memeel Memeel changed the title Fix for issue 14082 Replaces the standard ComboBox with a SearchableComboBox in custom Entry Types Oct 27, 2025
@Memeel Memeel changed the title Replaces the standard ComboBox with a SearchableComboBox in custom Entry Types Replaces the standard ComboBox with a SearchableComboBox in custom Entry Types (#14082) Oct 27, 2025
@Memeel Memeel changed the title Replaces the standard ComboBox with a SearchableComboBox in custom Entry Types (#14082) Replaces the standard ComboBox with a SearchableComboBox in custom Entry Types Oct 27, 2025
@Siedlerchr
Copy link
Member

Free text field is missing

@Memeel Memeel marked this pull request as draft October 27, 2025 17:18
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No changes to project files

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. Sorry, I accidentally removed a line in a previous commit, and the latest one reintroduces it

Memeel and others added 3 commits October 28, 2025 14:14
Replaces the single editable SearchableComboBox with two separate components: a SearchableComboBox for existing fields and a new TextField for custom fields
@Memeel Memeel changed the title Replaces the standard ComboBox with a SearchableComboBox in custom Entry Types Replaces the standard ComboBox with a SearchableComboBox and a free text field in custom Entry Types Oct 28, 2025
@Memeel
Copy link
Author

Memeel commented Oct 28, 2025

Just to make sure we are not misunderstanding the task, are we supposed to add another box below the existing one that lets you add the free text field, or should we keep a single combobox that has the searchable feature and the adding free text field?

@Siedlerchr
Copy link
Member

Siedlerchr commented Oct 28, 2025

As a User I want to search for existing fields and also have the option to create a new, not yet existing one, e.g. "mycustomfield" . If this is possible with the SearchableCombobox then it's good, otherwise add a new text field where the user can enter the fieldname

@Memeel Memeel marked this pull request as ready for review October 28, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Change combo box for field selection to two

4 participants