Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented Dec 2, 2025

Triggered by following wall of unaddressed changes

grafik

We cannot go through all PRs manually.

I propose to remind a contributor after 14 days and auto close 7 days later. We could also do 10 +10 or 7 + 14.

Steps to test

Merge and see the bot running.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] I manually tested my changes in running JabRef (always required)
  • [/] I added JUnit tests for changes (if applicable)
  • [/] I added screenshots in the PR description (if change is visible to the user)
  • [/] I described the change in CHANGELOG.md in a way that is understandable for the average user (if change is visible to the user)
  • [/] I checked the user documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request updating file(s) in https://github.com/JabRef/user-documentation/tree/main/en.

@Siedlerchr
Copy link
Member

Siedlerchr commented Dec 2, 2025

SO you want to notify the contributor when he did not do any changes. after we added the label=?

@koppor
Copy link
Member Author

koppor commented Dec 2, 2025

SO you want to notify the contributor when he did not do any changes. after we added the label=?

Yes.

Steps:

  1. Contributor pushes
  2. Tests fail.
  3. Label "status: changes-required" added
  4. Bot comments "Test X failed. Please fix it."
  5. Contributor does nothing.
  6. 14 days pass
  7. Bot comments: "Hey, wake up. Do something"
  8. Contributor does nothing.
  9. 7 days pass
  10. Bot closes the PR.

The bot can be stopped if label: "status: changes-required" is removed.

Label will be added automatically on

  • push (which is activity) and failing tests
  • conflicts with main branch (and from external contributor)

Siedlerchr
Siedlerchr previously approved these changes Dec 2, 2025
Co-authored-by: Subhramit Basu <subhramit.bb@live.in>
@Siedlerchr Siedlerchr enabled auto-merge December 3, 2025 22:03
@Siedlerchr Siedlerchr added this pull request to the merge queue Dec 3, 2025
Merged via the queue into main with commit 34d2a83 Dec 3, 2025
52 checks passed
@Siedlerchr Siedlerchr deleted the add-stale branch December 3, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants