Fix dropdown text clipping in non-Chinese locales#141
Merged
Conversation
Two ComboBoxes pinned a fixed pixel Width sized for short Chinese strings. Longer translations (e.g. de-DE "Win10 Klassischer Rechtsklick-Menüstil", pt-BR "Estilo clássico de menu de contexto do Win10", de-DE "Internet-Wörterbuch", tr-TR "Kullanıcı Sözlükleri") overflowed and the selection text was clipped. Switch Width to MinWidth so WPF auto-grows the ComboBox to its widest item. The parent MyListItem places controls in a GridLength.Auto column, so the row absorbs the extra width without breaking the title layout. This matches the pattern already used elsewhere (LanguagesView, SelectDialog, BackupDialog).
Jack251970
approved these changes
Apr 23, 2026
Owner
Jack251970
left a comment
Jack251970
left a comment
There was a problem hiding this comment.
Thanks for your contribution!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SwitchDicListandShellList's Win11/Win10 menu-style toggle) were created with a fixedWidthin pixels, sized for short Chinese strings. Longer translations like de-DE "Win10 Klassischer Rechtsklick-Menüstil", pt-BR "Estilo clássico de menu de contexto do Win10", de-DE "Internet-Wörterbuch", and tr-TR "Kullanıcı Sözlükleri" overflowed, and the selection text was clipped.WidthwithMinWidthso WPF auto-measures each ComboBox to its widest item. The parentMyListItemputs controls in aGridLength.Autocolumn, so the row grows without breaking the title layout. Same pattern is already used inLanguagesView,SelectDialog, andBackupDialog.MinWidth(or live in star-sized grid cells). OtherWidth = Nmatches areNumberBoxnumeric inputs and icon hosts, not text-bearing dropdowns.