Ints view by JackLeeHal · Pull Request #3 · JackLeeHal/sysl

JackLeeHal · 2019-06-12T08:05:46Z

Fixes # .

Changes proposed in this pull request:

Generate Integration view
Use antlr to parse epfmt and appfmt

linwumeng · 2019-06-13T03:35:57Z

Why not use stream instead of for loop?

import github.com/yale8848/stream to fix this.

linwumeng · 2019-06-13T03:37:17Z

Looks quite similar with FindHighlights. May be refactored.

linwumeng · 2019-06-13T08:34:27Z

a,b are not good name. Maybe s for string, i for item would be better. stringInSlice is weird, maybe 'find' or 'lookup'.

linwumeng · 2019-06-13T08:55:28Z

prefer to 'o' instead of 'r' which means outputs.

I thought use 'r' as the shorthand for 'result'. It seems 'o' would be better than it, right?

linwumeng · 2019-06-13T09:20:33Z

why make a copy?

useless logic. remove the copy.

linwumeng · 2019-06-13T09:25:37Z

if other is nil or empty, s can be returned if it is not nil or empty. think about these corner cases.

add logic to handle empty case when other is empty.

linwumeng · 2019-06-13T09:28:12Z

All miss boundary testing, nil and empty, and negative test cases.

* Fix issue anz-bank#232 and anz-bank#233 * Add default value for SYSL_PLANTUML * Add kingpin package to handle command-line args * Align command-line args with python

…#238) * New documentation on installing plantuml server for mac osx * add gradle to travis

Enable all golangci-lint linters Temporarily suppress unparam for two functions

* Pin .golangci.yaml to golangci-lint 1.17.1 * Remove golangci-lint from travis build (golangci.com now does it).

Also remove SYSL_PYTHON_BIN from CI build

JackLeeHal force-pushed the intsView branch 2 times, most recently from 0353ccb to 5d4effd Compare June 12, 2019 09:12

linwumeng suggested changes Jun 13, 2019

View reviewed changes

Fix issue anz-bank#232 and anz-bank#233 (anz-bank#234)

a3444f1

* Fix issue anz-bank#232 and anz-bank#233 * Add default value for SYSL_PLANTUML * Add kingpin package to handle command-line args * Align command-line args with python

JackLeeHal force-pushed the intsView branch 4 times, most recently from fa000e8 to 8c987ec Compare June 17, 2019 09:14

loki5265 force-pushed the intsView branch 3 times, most recently from 59a0d80 to 0009d89 Compare June 20, 2019 03:31

JackLeeHal force-pushed the intsView branch 2 times, most recently from e720881 to 1a0a174 Compare June 21, 2019 02:29

loki5265 force-pushed the intsView branch from 4a78c4d to 934748e Compare June 24, 2019 06:09

JackLeeHal force-pushed the intsView branch from 67d31de to b21932d Compare June 25, 2019 07:47

New documentation on installing plantuml server for mac osx (anz-bank…

36c607c

…#238) * New documentation on installing plantuml server for mac osx * add gradle to travis

JackLeeHal force-pushed the intsView branch 3 times, most recently from 397ace6 to cdedf15 Compare June 27, 2019 02:16

loki5265 force-pushed the intsView branch 2 times, most recently from 107cfac to e274e93 Compare June 27, 2019 05:47

JackLeeHal force-pushed the intsView branch from e274e93 to 667a439 Compare June 28, 2019 03:08

loki5265 force-pushed the intsView branch from 667a439 to e317604 Compare June 28, 2019 05:52

JackLeeHal force-pushed the intsView branch 2 times, most recently from 1e54397 to 2334a93 Compare June 28, 2019 09:09

loki5265 force-pushed the intsView branch 2 times, most recently from 463e2b6 to c26d3e0 Compare July 4, 2019 07:19

anzdaddy added 3 commits July 8, 2019 16:22

Configure golangci-lint & address its warnings

c42bd21

Add linters: bodyclose, depguard, dupl

a05cf31

Add linter gocritic

03aa113

anzdaddy added 9 commits July 9, 2019 02:34

Add linter: gochecknoinits + de-noise logging

0cd576c

Add linter: goconst

5da53a2

Add linter: gocyclo

f0e5fb6

Add linter: golint

4a5586f

Add linter: gochecknoglobals

a5f9114

Add linter: gosec

1135760

Simplify linter config (enable-all)

4cc0a65

Add golangci-lint to .travis.yml

ff8bee2

Add golangci-lint to .travis.yml install section

3dd539f

loki5265 force-pushed the intsView branch from 9ed6bdb to 64248b1 Compare July 9, 2019 03:50

JackLeeHal force-pushed the intsView branch 2 times, most recently from 466a337 to 1fb105d Compare July 11, 2019 06:01

anzdaddy and others added 2 commits July 11, 2019 16:09

Temporarily suppress unparam for two functions.

70cc64d

Anzdaddy/golangci lint (anz-bank#242)

bdbd0a7

Enable all golangci-lint linters Temporarily suppress unparam for two functions

JackLeeHal force-pushed the intsView branch 3 times, most recently from 3d47a7e to a75d23f Compare July 11, 2019 09:13

loki5265 force-pushed the intsView branch 2 times, most recently from 289b56a to bff21e8 Compare July 12, 2019 05:42

JackLeeHal force-pushed the intsView branch from 992674d to 57adbcd Compare July 12, 2019 08:05

loki5265 force-pushed the intsView branch from c9f1ca9 to fb94d94 Compare July 16, 2019 08:28

JackLeeHal force-pushed the intsView branch from 505509a to 6a849ff Compare July 17, 2019 03:32

anzdaddy added 2 commits July 18, 2019 10:42

Move to golangci.com for linting (anz-bank#253)

70ef117

* Pin .golangci.yaml to golangci-lint 1.17.1 * Remove golangci-lint from travis build (golangci.com now does it).

Replace PySysl validation with compare-to-golden (anz-bank#252)

eafd60c

Also remove SYSL_PYTHON_BIN from CI build

JackLeeHal force-pushed the intsView branch 2 times, most recently from 4791fff to e91f094 Compare July 18, 2019 05:39

Generate integration diagram

d5c3691

JackLeeHal force-pushed the intsView branch from e91f094 to d5c3691 Compare July 18, 2019 06:09

Allenhaoli added 2 commits July 18, 2019 14:22

sysl file tab issue

9664741

fix ci issue

db54062

Conversation

JackLeeHal commented Jun 12, 2019

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants