feat: Phase 1.1 - Extract API Service #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit extracts the web/API service from the monolith into a dedicated services/api package as part of the microservices migration. Changes: - Created services/api/ directory structure with src/byte_api/ - Moved byte_bot/server/ code to services/api/src/byte_api/ - Updated all imports from byte_bot.server to byte_api - Updated models to use byte_common shared package - Created services/api/pyproject.toml with dependencies - Created production Dockerfile for API service - Updated workspace configuration to include services/api - Fixed circular import in settings.py (removed byte_bot.__metadata__) - Added ruff per-file ignores for API service Note: Full runtime testing blocked until Phase 1.4 (old structure removal) due to SQLAlchemy MetaData conflicts and Litestar entry point discovery. Related to #103 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Sorry @JacobCoffee, your pull request is larger than the review limit of 150000 diff characters
|
🚅 Deployed to the byte-pr-107 environment in byte
|
Update ty type checker configuration to include the new API service path so it can resolve byte_api imports during type checking. Fixes CI validation failure in PR #107 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
This was referenced Nov 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR completes Phase 1.1 of the microservices migration, extracting the web/API service from the monolith into a dedicated
services/apipackage.Changes
Service Structure
services/api/directory withsrc/byte_api/package structurebyte_bot/server/toservices/api/src/byte_api/byte_bot.servertobyte_apiservices/api/pyproject.tomlwith proper dependencies and workspace configurationDockerfilefor API service deploymentDependencies & Configuration
services/apibyte-commonpackage as workspace dependencybyte_common.modelsinstead of local definitionsbyte_bot.__metadata__dependency)File Summary
Testing Notes
What was tested:
uv syncFull testing will be possible after:
Related
Test Plan
🤖 Generated with Claude Code