feat: Phase 3.2 - Add retry logic and circuit breakers to API client #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add tenacity>=8.2.0 to bot service dependencies to enable retry logic with exponential backoff for API client. Part of Phase 3.2 - Retry Logic & Circuit Breakers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add tenacity-based retry decorators to all API client methods: - Retry on HTTP 5xx errors and connection errors - No retry on HTTP 4xx (client errors) - Max 3 attempts with exponential backoff (1s, 2s, 4s, max 10s) - Retry statistics tracking per method with TypedDict - Logging before each retry attempt Methods with retry logic: - create_guild - get_guild - update_guild - delete_guild - health_check Part of Phase 3.2 - Retry Logic & Circuit Breakers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add 25+ test cases covering: - Retry on HTTP 5xx errors (500, 502, 503) - No retry on HTTP 4xx errors (400, 404) - Retry on connection errors (ConnectError, ConnectTimeout, ReadTimeout) - Max retry attempts (3 attempts) - Retry statistics tracking across methods - Exponential backoff timing verification - Composite method retry behavior (get_or_create_guild) Test coverage: - create_guild retry behavior - get_guild retry behavior - update_guild retry behavior - delete_guild retry behavior - health_check retry behavior - Retry statistics initialization and tracking - Failed request tracking (4xx errors) Part of Phase 3.2 - Retry Logic & Circuit Breakers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Add comprehensive documentation for retry behavior: - Configuration (max retries, backoff, timeouts) - Retryable vs non-retryable errors - Retry statistics tracking - Logging behavior - Example usage Updated Status section to reflect Phase 3.2 completion. Part of Phase 3.2 - Retry Logic & Circuit Breakers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed retry logic to properly re-raise original httpx exceptions (HTTPStatusError, RequestError) when retries should occur, allowing tenacity to handle the retry logic. Changes: - Re-raise original exception when _should_retry() returns True - Only convert to APIError for non-retryable errors (4xx) - Updated test to expect HTTPStatusError after max retries exhausted - All 17 retry tests now pass This ensures tenacity can properly retry requests while still tracking statistics and converting non-retryable errors to APIError. Part of Phase 3.2 - Retry Logic & Circuit Breakers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Updated existing API client tests to expect original httpx exceptions (HTTPStatusError, ConnectError, TimeoutException) instead of APIError when retryable errors occur, aligning with the new retry logic behavior. Changes: - test_create_guild_server_error: expect HTTPStatusError - test_create_guild_connection_error: expect ConnectError - test_create_guild_timeout: expect TimeoutException - test_get_guild_server_error: expect HTTPStatusError - test_get_guild_connection_error: expect ConnectError - test_update_guild_connection_error: expect ConnectError - test_delete_guild_server_error: expect HTTPStatusError - test_delete_guild_connection_error: expect ConnectError - test_health_check_unhealthy: expect HTTPStatusError - test_health_check_connection_error: expect ConnectError - test_health_check_timeout: expect TimeoutException All tests document retry-then-fail behavior in docstrings. Part of Phase 3.2 - Retry Logic & Circuit Breakers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
🚅 Deployed to the byte-pr-133 environment in byte
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Sorry @JacobCoffee, you have reached your weekly rate limit of 500000 diff characters.
Please try again later or upgrade to continue using Sourcery
- Combine retry logic with correlation ID tracking from main - Keep both RetryStats tracking and X-Correlation-ID headers - Preserve all retry decorators and exponential backoff logic 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
|
Documentation preview will be available shortly at https://jacobcoffee.github.io/byte-docs-preview/133 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Implements Phase 3.2 from PLAN.md - adds robust retry logic with exponential backoff to the API client.
Changes
tenacitylibrary for retry logicTest Coverage
Implementation Details
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com