-
-
Notifications
You must be signed in to change notification settings - Fork 1
feat: update dependencies and build infrastructure #91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Update dependency lock file (uv.lock) - Add Python 3.12 support to .tool-versions - Update pre-commit to use Python 3.12 - Add new Makefile targets for container management - Fix Railway deployment command in nixpacks.toml - Add 'thirdparty' to codespell ignore list This foundational update prepares for guild settings feature development while maintaining backward compatibility.
Reviewer's GuideThis PR updates project dependencies and build infrastructure by adding Python 3.12 support, refreshing the lock file, introducing Docker-based Makefile targets, correcting the nixpacks startup command, and extending the codespell ignore list. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @JacobCoffee - I've reviewed your changes and they look great!
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location> `Makefile:68` </location>
<code_context>
+ @docker compose -f docker-compose.infra.yml up -d
+ @echo "=> Started Byte database container"
+
+clean-container: ## Stop, remove, and wipe the Byte database container and volume
+ @echo "=> Stopping and removing Byte database container"
+ @docker stop byte-db-1
</code_context>
<issue_to_address>
Use `docker compose down -v` to clean up container and volume in one step
Switch to `docker compose -f docker-compose.infra.yml down -v --remove-orphans` for a more comprehensive and efficient cleanup of containers, volumes, networks, and orphans.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
clean-container: ## Stop, remove, and wipe the Byte database container and volume
@echo "=> Stopping and removing Byte database container"
@docker stop byte-db-1
@docker rm byte-db-1
@docker volume rm byte_db-data
@echo "=> Stopped and removed Byte database container"
=======
clean-container: ## Stop, remove, and wipe the Byte database container, volume, network, and orphans
@echo "=> Stopping and removing Byte database container, volumes, networks, and orphans"
@docker compose -f docker-compose.infra.yml down -v --remove-orphans
@echo "=> Stopped and removed Byte database container, volumes, networks, and orphans"
>>>>>>> REPLACE
</suggested_fix>
### Comment 2
<location> `Makefile:63` </location>
<code_context>
@$(MAKE) install-frontend
@echo "=> Install complete! Note: If you want to re-install re-run 'make install'"
+up-container: ## Start the Byte database container
+ @echo "=> Starting Byte database container"
+ @docker compose -f docker-compose.infra.yml up -d
</code_context>
<issue_to_address>
Parameterize container and volume names for easier maintenance
Defining variables for these names at the top of the Makefile will help prevent inconsistencies if they need to be updated.
</issue_to_address>
### Comment 3
<location> `Makefile:75` </location>
<code_context>
+ @docker volume rm byte_db-data
+ @echo "=> Stopped and removed Byte database container"
+
+load-container: migrate ## Perform database migrations and load test data into the Byte database container
+ @echo "=> Loading database migrations and test data"
+ @$(UV) run app database upgrade --no-prompt
</code_context>
<issue_to_address>
Add `up-container` as a dependency of `load-container`
This ensures the database container is running before migrations are applied, preventing errors if someone runs `make load-container` directly.
</issue_to_address>
<suggested_fix>
<<<<<<< SEARCH
load-container: migrate ## Perform database migrations and load test data into the Byte database container
=======
load-container: up-container migrate ## Perform database migrations and load test data into the Byte database container
>>>>>>> REPLACE
</suggested_fix>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Description
This foundational update prepares for guild settings feature development while maintaining backward compatibility.
Close Issue(s)
Summary by Sourcery
Update dependencies, add Python 3.12 support, introduce Makefile targets for container management, fix deployment configuration, and extend codespell ignores
New Features:
Enhancements:
Build:
Deployment: