-
Notifications
You must be signed in to change notification settings - Fork 14
Fix for building against musl libc #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for building against musl libc #6
Conversation
This fix enables the package to be built against [musl libc](https://www.musl-libc.org/) instead of glibc. Musl libc is used in the Linux Alpine distro and since the [official Node.js Docker repo](https://hub.docker.com/_/node/) advertises its Alpine based images as "highly recommended when final image size being as small as possible is desired", it turns out that quite a few people run Node.js on Alpine via these images. This change should not have any impact on systems that use the more widespread glibc, as the updated imports should be available in all libc variants.
|
I've used the following Dockerfiles to verify the package in Alpine and Jessie. I did not verify anything in Windows, though. Alpine, Node 10 Jessie, Node 10. Alpine, Node 8 The node-gyp build finished with |
|
Thanks! I'll double check this evening to make sure everything seems solid, and if so I'll merge this PR and update the package to 1.1.1. |
|
Sounds great! Thanks. |
|
Yup looks good! |
|
Thanks for merging and publishing! 🎉 |
See JacobFischer/netlinkwrapper#6 and JacobFischer/netlinkwrapper@813742a This fix enables the installation of the optional dependency netlinkwrapper (necessary for reporting uncaught exceptions) on systems that use [musl libc](https://www.musl-libc.org/) instead of glibc. Musl libc is used in the Linux Alpine distro and since the [official Node.js Docker repo](https://hub.docker.com/_/node/) advertises its Alpine based images as "highly recommended when final image size being as small as possible is desired", it turns out that quite a few people run Node.js on Alpine via these images. This change should not have any impact on systems that use the more widespread glibc, as the updated imports in netlinkwrapper should be available in all libc variants.
See JacobFischer/netlinkwrapper#6 and JacobFischer/netlinkwrapper@813742a This fix enables the installation of the optional dependency netlinkwrapper (necessary for reporting uncaught exceptions) on systems that use [musl libc](https://www.musl-libc.org/) instead of glibc. Musl libc is used in the Linux Alpine distro and since the [official Node.js Docker repo](https://hub.docker.com/_/node/) advertises its Alpine based images as "highly recommended when final image size being as small as possible is desired", it turns out that quite a few people run Node.js on Alpine via these images. This change should not have any impact on systems that use the more widespread glibc, as the updated imports in netlinkwrapper should be available in all libc variants.
See JacobFischer/netlinkwrapper#6 and JacobFischer/netlinkwrapper@813742a This fix enables the installation of the optional dependency netlinkwrapper (necessary for reporting uncaught exceptions) on systems that use [musl libc](https://www.musl-libc.org/) instead of glibc. Musl libc is used in the Linux Alpine distro and since the [official Node.js Docker repo](https://hub.docker.com/_/node/) advertises its Alpine based images as "highly recommended when final image size being as small as possible is desired", it turns out that quite a few people run Node.js on Alpine via these images. This change should not have any impact on systems that use the more widespread glibc, as the updated imports in netlinkwrapper should be available in all libc variants.
Fix for building against musl libc
This fix enables the package to be built against
musl libc instead of glibc. Musl libc is
used in the Linux Alpine distro and since the
official Node.js Docker repo
advertises its Alpine based images as "highly recommended
when final image size being as small as possible is desired", it turns
out that quite a few people run Node.js on Alpine via these images.
This change should not have any impact on systems that use the more
widespread glibc, as the updated imports should be available in all
libc variants.