fix: stance spectrum classification and enhanced grading UI#120
Merged
Conversation
- Add stance_category to Stage 1/2 AI classifiers so stanceSnapshot correctly produces pro-strong/weak and con-strong/weak instead of always returning "neutral" - Remove stanceSnapshot from Stage 3/4 handlers (no stance changes) - Enhance teacher grading modal with conversation history, AI summary, and assessment dimension scores Closes #119 Closes #116 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Deploying mentora-app with
|
| Latest commit: |
988e250
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://54b617d2.mentora-app.pages.dev |
| Branch Preview URL: | https://fix-stance-analysis-and-grad.mentora-app.pages.dev |
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Owner
|
Please run e2e and if possible attach the recorded video so it is easier for others to review. |
Set up Playwright with video recording to demonstrate the enhanced grading UI (AI assessment dimensions, conversation history). Includes Firebase emulator data seeding and IndexedDB-based auth injection. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
Author
E2E Test ResultsAdded Playwright e2e tests with video recording for the grading modal UI. Setup
Run# Start Firebase emulator + dev server first, then:
pnpm --filter mentora test:e2eTest coverage
E2E Recording
ScreenshotsGrading Modal — AI Assessment & Conversation Grading Modal — Score Input Filled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
stance_category欄位，使stanceSnapshot能正確產生pro-strong/weak、con-strong/weak分類，而非永遠回傳"neutral"。Stage 3/4 移除不必要的stanceSnapshot（這些階段不涉及立場變更）。xl尺寸，開啟時自動載入學生的完整對話紀錄、AI 總結分析、以及 5 維度 AI 評估分數（含回饋），讓老師在充分資訊下進行評分。Closes #119
Closes #116
Test plan
🤖 Generated with Claude Code