chore(health): allowing the checker to be called async#21
Merged
Jacobbrewer1 merged 2 commits intomainfrom Apr 10, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
health/checker_options.go:7
- [nitpick] Consider handling the error returned by AddCheck instead of discarding it. Addressing this would help catch issues like duplicate or nil checks that might otherwise go unnoticed.
return func(c *Checker) { _ = c.AddCheck(check) }
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pull request includes significant changes to the
healthpackage, primarily focusing on refactoring theCheckerstruct and related functionalities. The changes include converting thecheckerstruct toChecker, updating methods and tests accordingly, and removing theMockCheckerimplementation.Refactoring of
Checkerstruct and related functionalities:health/checker.go: Converted thecheckerstruct toChecker, updated theCheckmethod to usesync.Mapfor storing checks, and added theAddCheckmethod for adding checks to theChecker. [1] [2] [3] [4] [5]health/checker_options.go: UpdatedCheckerOptiontype and related functions to work with the newCheckerstruct. [1] [2]Updates to tests and documentation:
health/checker_test.go: Modified tests to align with the newCheckerstruct implementation. [1] [2]health/check.go: Improved documentation for theNewCheckfunction to specify that each check should have a unique name.Removal of obsolete mock implementation:
health/mock_Checker.go: Removed theMockCheckerimplementation as it is no longer needed with the newCheckerstruct.health/mock_CheckerOption.go: Updated theMockCheckerOptionto work with the newCheckerstruct.