chore(app): allowing the user to specify the retention for the nats jetstream#24
Merged
Jacobbrewer1 merged 2 commits intomainfrom Apr 11, 2025
Merged
chore(app): allowing the user to specify the retention for the nats jetstream#24Jacobbrewer1 merged 2 commits intomainfrom
Jacobbrewer1 merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
options.go:320
- [nitpick] Consider updating the function's comment block (above line 319) to document the new retentionPolicy parameter and its expected values for better clarity for the function's users.
func WithNatsJetStream(streamName string, retentionPolicy jetstream.RetentionPolicy, subjects []string) StartOption {
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pull request includes changes to the
WithNatsJetStreamfunction in theoptions.gofile to add more flexibility in configuring the NATS JetStream retention policy.Enhancements to NATS JetStream configuration:
options.go: Modified theWithNatsJetStreamfunction to accept aretentionPolicyparameter in addition tostreamNameandsubjects. This allows for more flexible configuration of the JetStream retention policy.options.go: Updated theRetentionfield in the JetStream configuration to use the newretentionPolicyparameter instead of the hardcodedjetstream.WorkQueuePolicy.