Skip to content

chore(app): allowing the user to specify the retention for the nats jetstream#24

Merged
Jacobbrewer1 merged 2 commits intomainfrom
chore/jetsream-retention
Apr 11, 2025
Merged

chore(app): allowing the user to specify the retention for the nats jetstream#24
Jacobbrewer1 merged 2 commits intomainfrom
chore/jetsream-retention

Conversation

@Jacobbrewer1
Copy link
Owner

Describe your changes

This pull request includes changes to the WithNatsJetStream function in the options.go file to add more flexibility in configuring the NATS JetStream retention policy.

Enhancements to NATS JetStream configuration:

  • options.go: Modified the WithNatsJetStream function to accept a retentionPolicy parameter in addition to streamName and subjects. This allows for more flexible configuration of the JetStream retention policy.
  • options.go: Updated the Retention field in the JetStream configuration to use the new retentionPolicy parameter instead of the hardcoded jetstream.WorkQueuePolicy.

@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 11, 2025 08:52
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

options.go:320

  • [nitpick] Consider updating the function's comment block (above line 319) to document the new retentionPolicy parameter and its expected values for better clarity for the function's users.
func WithNatsJetStream(streamName string, retentionPolicy jetstream.RetentionPolicy, subjects []string) StartOption {

@Jacobbrewer1 Jacobbrewer1 enabled auto-merge (squash) April 11, 2025 08:53
@Jacobbrewer1 Jacobbrewer1 disabled auto-merge April 11, 2025 08:53
@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 11, 2025 08:53
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no comments.

@Jacobbrewer1 Jacobbrewer1 enabled auto-merge (squash) April 11, 2025 08:54
@Jacobbrewer1 Jacobbrewer1 merged commit d5d095b into main Apr 11, 2025
5 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the chore/jetsream-retention branch April 11, 2025 08:56
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 12, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants