Skip to content

feat(app): adding potential informers#29

Merged
Jacobbrewer1 merged 4 commits intomainfrom
feat/pod-informers
Apr 15, 2025
Merged

feat(app): adding potential informers#29
Jacobbrewer1 merged 4 commits intomainfrom
feat/pod-informers

Conversation

@Jacobbrewer1
Copy link
Owner

Describe your changes

This pull request introduces significant enhancements to the Kubernetes integration within the application. The changes include adding Kubernetes informers and listers, updating the service endpoint hash bucket, and providing new options for initializing Kubernetes informers.

Kubernetes Integration Enhancements:

  • app.go: Added new imports for Kubernetes informers, listers, and cache tools. Introduced new fields in the App struct for Kubernetes informer factory, pod informer, and pod lister. Updated the serviceEndpointHashBucket type to a pointer. Added methods to return the Kubernetes informer factory, pod informer, and pod lister. [1] [2] [3] [4]

  • options.go: Added a new import for Kubernetes informers. Introduced a new WithKubernetesPodInformer StartOption to initialize a Kubernetes SharedInformerFactory and informer for Kubernetes Pod objects. [1] [2]

  • options_helpers.go: Created a new file to define the initKubernetesInformerFactory function, which initializes the Kubernetes informer factory for the App.

@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 15, 2025 11:34
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

app.go:89

  • The comment refers to 'pod listener' instead of 'pod lister'. Consider updating it to accurately reflect that this field is a pod lister.
// podLister is the pod listener for the application.

@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 15, 2025 11:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 15, 2025 11:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@Jacobbrewer1 Jacobbrewer1 marked this pull request as ready for review April 15, 2025 11:40
@Jacobbrewer1 Jacobbrewer1 merged commit 6c610cc into main Apr 15, 2025
5 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the feat/pod-informers branch April 15, 2025 11:40
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 16, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants