feat(app): adding potential informers#29
Merged
Jacobbrewer1 merged 4 commits intomainfrom Apr 15, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
app.go:89
- The comment refers to 'pod listener' instead of 'pod lister'. Consider updating it to accurately reflect that this field is a pod lister.
// podLister is the pod listener for the application.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe your changes
This pull request introduces significant enhancements to the Kubernetes integration within the application. The changes include adding Kubernetes informers and listers, updating the service endpoint hash bucket, and providing new options for initializing Kubernetes informers.
Kubernetes Integration Enhancements:
app.go: Added new imports for Kubernetes informers, listers, and cache tools. Introduced new fields in theAppstruct for Kubernetes informer factory, pod informer, and pod lister. Updated theserviceEndpointHashBuckettype to a pointer. Added methods to return the Kubernetes informer factory, pod informer, and pod lister. [1] [2] [3] [4]options.go: Added a new import for Kubernetes informers. Introduced a newWithKubernetesPodInformerStartOption to initialize a Kubernetes SharedInformerFactory and informer for Kubernetes Pod objects. [1] [2]options_helpers.go: Created a new file to define theinitKubernetesInformerFactoryfunction, which initializes the Kubernetes informer factory for theApp.