Skip to content

feat(app): adding secret informers#30

Merged
Jacobbrewer1 merged 2 commits intomainfrom
feat/secret-informers
Apr 16, 2025
Merged

feat(app): adding secret informers#30
Jacobbrewer1 merged 2 commits intomainfrom
feat/secret-informers

Conversation

@Jacobbrewer1
Copy link
Owner

Describe your changes

This pull request introduces functionality to handle Kubernetes Secret objects in addition to the existing Pod objects. The main changes include adding informers and listers for Secrets and creating a new option to initialize these components.

Kubernetes Secret handling:

  • app.go: Added secretInformer and secretLister fields to the App struct and implemented SecretLister and SecretInformer methods. [1] [2]
  • options.go: Added the WithKubernetesSecretInformer function to initialize the Kubernetes SharedInformerFactory and informer for Secret objects.

@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 16, 2025 10:05
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

options.go:369

  • [nitpick] Consider updating the error message to reference the secret informer setup rather than only mentioning the secret lister for improved clarity.
return errors.New("must set up kube client before secret lister, ensure WithInClusterKubeClient is called")

@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 16, 2025 10:06
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request adds support for handling Kubernetes Secret objects alongside Pod objects. The changes include adding secret informer and lister fields along with their accessor methods in app.go, and introducing the WithKubernetesSecretInformer function in options.go to initialize the Secret informer.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
options.go Updated error message for pod informer and added secret informer initialization.
app.go Added secret informer and lister fields and accessor methods.

@Jacobbrewer1 Jacobbrewer1 marked this pull request as ready for review April 16, 2025 10:07
@Jacobbrewer1 Jacobbrewer1 merged commit 25d7b90 into main Apr 16, 2025
5 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the feat/secret-informers branch April 16, 2025 10:08
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 17, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants