Conversation
There was a problem hiding this comment.
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (1)
options.go:369
- [nitpick] Consider updating the error message to reference the secret informer setup rather than only mentioning the secret lister for improved clarity.
return errors.New("must set up kube client before secret lister, ensure WithInClusterKubeClient is called")
There was a problem hiding this comment.
Pull Request Overview
This pull request adds support for handling Kubernetes Secret objects alongside Pod objects. The changes include adding secret informer and lister fields along with their accessor methods in app.go, and introducing the WithKubernetesSecretInformer function in options.go to initialize the Secret informer.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| options.go | Updated error message for pod informer and added secret informer initialization. |
| app.go | Added secret informer and lister fields and accessor methods. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Describe your changes
This pull request introduces functionality to handle Kubernetes Secret objects in addition to the existing Pod objects. The main changes include adding informers and listers for Secrets and creating a new option to initialize these components.
Kubernetes Secret handling:
app.go: AddedsecretInformerandsecretListerfields to theAppstruct and implementedSecretListerandSecretInformermethods. [1] [2]options.go: Added theWithKubernetesSecretInformerfunction to initialize the Kubernetes SharedInformerFactory and informer for Secret objects.