Skip to content

fix(deps): using fixed version of vault sql#46

Merged
Jacobbrewer1 merged 2 commits intomainfrom
fix/vsql-version
Apr 21, 2025
Merged

fix(deps): using fixed version of vault sql#46
Jacobbrewer1 merged 2 commits intomainfrom
fix/vsql-version

Conversation

@Jacobbrewer1
Copy link
Owner

Describe your changes

This pull request introduces a new test for the waitUntilStarted method in the app_test.go file and updates a dependency in the go.mod file. These changes enhance the test coverage and ensure the project uses the latest version of a library.

Testing Improvements:

  • app_test.go: Added a new test, TestApp_WaitUntilStarted, to verify the behavior of the waitUntilStarted method. The test ensures the method waits for the application to start and handles subsequent calls correctly.

Dependency Updates:

  • go.mod: Updated the github.com/jacobbrewer1/vaulty dependency from version v0.1.12 to v0.1.13.

@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 21, 2025 08:33
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR improves test coverage for the application's startup logic and updates a dependency to a fixed version.

  • Added TestApp_WaitUntilStarted in app_test.go to verify the waitUntilStarted behavior
  • Updated dependency github.com/jacobbrewer1/vaulty from v0.1.12 to v0.1.13

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.

File Description
app_test.go Added a new test to verify the waitUntilStarted method's behavior
go.mod Updated dependency version for github.com/jacobbrewer1/vaulty
Files not reviewed (1)
  • go.mod: Language not supported

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 21, 2025 08:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

A PR to enhance test coverage by adding a new test for the waitUntilStarted method and to update a dependency version for improved reliability.

  • Added TestApp_WaitUntilStarted in app_test.go to verify that waitUntilStarted behaves correctly during startup and subsequent calls.
  • Updated the github.com/jacobbrewer1/vaulty dependency from v0.1.12 to v0.1.13 in go.mod.

Reviewed Changes

Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.

File Description
app_test.go Introduces a test for waitUntilStarted with proper timeout checks
go.mod Updates the fixed version of the vault SQL dependency
Files not reviewed (1)
  • go.mod: Language not supported

@Jacobbrewer1 Jacobbrewer1 marked this pull request as ready for review April 21, 2025 08:36
@Jacobbrewer1 Jacobbrewer1 enabled auto-merge (squash) April 21, 2025 08:36
@Jacobbrewer1 Jacobbrewer1 merged commit 8bd00ae into main Apr 21, 2025
5 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the fix/vsql-version branch April 21, 2025 08:37
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 22, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants