fix(deps): using fixed version of vault sql#46
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves test coverage for the application's startup logic and updates a dependency to a fixed version.
- Added TestApp_WaitUntilStarted in app_test.go to verify the waitUntilStarted behavior
- Updated dependency github.com/jacobbrewer1/vaulty from v0.1.12 to v0.1.13
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| app_test.go | Added a new test to verify the waitUntilStarted method's behavior |
| go.mod | Updated dependency version for github.com/jacobbrewer1/vaulty |
Files not reviewed (1)
- go.mod: Language not supported
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull Request Overview
A PR to enhance test coverage by adding a new test for the waitUntilStarted method and to update a dependency version for improved reliability.
- Added TestApp_WaitUntilStarted in app_test.go to verify that waitUntilStarted behaves correctly during startup and subsequent calls.
- Updated the github.com/jacobbrewer1/vaulty dependency from v0.1.12 to v0.1.13 in go.mod.
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| app_test.go | Introduces a test for waitUntilStarted with proper timeout checks |
| go.mod | Updates the fixed version of the vault SQL dependency |
Files not reviewed (1)
- go.mod: Language not supported
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. |
Describe your changes
This pull request introduces a new test for the
waitUntilStartedmethod in theapp_test.gofile and updates a dependency in thego.modfile. These changes enhance the test coverage and ensure the project uses the latest version of a library.Testing Improvements:
app_test.go: Added a new test,TestApp_WaitUntilStarted, to verify the behavior of thewaitUntilStartedmethod. The test ensures the method waits for the application to start and handles subsequent calls correctly.Dependency Updates:
go.mod: Updated thegithub.com/jacobbrewer1/vaultydependency from versionv0.1.12tov0.1.13.