Skip to content

feat(repo): adding the editor config#53

Merged
Jacobbrewer1 merged 4 commits intomainfrom
feat/editor-config
Apr 23, 2025
Merged

feat(repo): adding the editor config#53
Jacobbrewer1 merged 4 commits intomainfrom
feat/editor-config

Conversation

@Jacobbrewer1
Copy link
Owner

Describe your changes

This pull request introduces an .editorconfig file to standardize code formatting across the project and reorganizes import statements in multiple files to improve readability and maintain consistency. The most significant changes are outlined below:

Code Formatting Standardization:

  • Added a new .editorconfig file to enforce consistent coding styles, including settings for character encoding, line endings, indentation, and maximum line length. Specific overrides were added for Bash, Go, YAML, and other file types.

Import Statement Reorganization:

  • app.go: Reorganized import statements to group related dependencies together, moving several internal packages (goredis, uhttp, vaulty, etc.) to a separate section for better clarity. [1] [2]
  • app_test.go: Adjusted the placement of the logging package import to maintain alphabetical order.
  • cache/service_endpoint_hash_bucket.go: Re-added imports for logging and slices in a new section to align with the import structure.
  • cache/service_endpoint_hash_bucket_test.go: Re-added the slices package import in a separate section to improve organization.
  • vault.go: Moved the viper package import to its correct alphabetical position.

@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 23, 2025 13:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces a standardized code formatting approach via a new .editorconfig file and reorganizes import statements across multiple files to improve clarity and consistency.

  • Added .editorconfig to enforce coding styles.
  • Reorganized internal and external package imports in several Go files for better readability.

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vault.go Moved "github.com/spf13/viper" import to the proper grouping and removed duplicate entry.
options.go Reordered internal package imports into a new grouping following external packages.
cache/service_endpoint_hash_bucket_test.go Re-added the "github.com/jacobbrewer1/web/slices" import in accordance with the new structure.
cache/service_endpoint_hash_bucket.go Adjusted logging and slices import positions to match the project's reorganization.
app_test.go Moved the logging import to maintain alphabetical order.
app.go Removed the original internal imports block and re-added them later in the file to ensure consistent ordering.
Files not reviewed (1)
  • .editorconfig: Language not supported

@Jacobbrewer1 Jacobbrewer1 marked this pull request as ready for review April 23, 2025 13:59
@Jacobbrewer1 Jacobbrewer1 requested a review from Copilot April 23, 2025 13:59
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces an .editorconfig file to standardize code formatting across the project and reorganizes import statements in multiple files to improve readability and consistency.

  • Added an .editorconfig file with rules for indentation, line endings, encoding, etc.
  • Reorganized import statements across several files to group and order dependencies more clearly.
  • Updated .golangci.yaml to enable gofmt simplification for cleaner formatting.

Reviewed Changes

Copilot reviewed 9 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
vault.go Moved the viper import to the proper section and removed its duplicate entry.
options.go Reorganized internal package imports into a new grouped section.
cache/service_endpoint_hash_bucket_test.go Adjusted the placement of the slices package import for grouping consistency.
cache/service_endpoint_hash_bucket.go Reordered logging and slices imports to a new consistent section.
app_test.go Adjusted logging import to maintain alphabetical order.
app.go Reorganized internal package imports into a new grouped section for clarity.
.golangci.yaml Updated gofmt settings to enable simplification.
Files not reviewed (1)
  • .editorconfig: Language not supported

@Jacobbrewer1 Jacobbrewer1 merged commit 12ec4df into main Apr 23, 2025
6 checks passed
@Jacobbrewer1 Jacobbrewer1 deleted the feat/editor-config branch April 23, 2025 14:00
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues.
If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants