Skip to content

fix(create-module): post-qa fixes#153

Merged
GauBen merged 6 commits intomainfrom
fix/hello-world
Mar 19, 2025
Merged

fix(create-module): post-qa fixes#153
GauBen merged 6 commits intomainfrom
fix/hello-world

Conversation

@GauBen
Copy link
Copy Markdown
Member

@GauBen GauBen commented Mar 10, 2025

Description

Fixes for bugs found during qa:

Checklist

Source code

  • I've considered the implications on security (in particular for changes to authentication, authorization, data fetching, ...)
  • I've considered the implications on performances
  • I've considered the implications on migration
  • I've considered the implications on code maintainability

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Documentation

  • I've provided inline documentation (Source code)
  • I've provided internal documentation (README, Confluence)
  • I've provided user-facing documentation (Academy)

Tip

Documentation to guide the reviews: How to do a code review

@GauBen GauBen marked this pull request as ready for review March 19, 2025 15:30
@GauBen GauBen requested a review from a team as a code owner March 19, 2025 15:30
Comment thread javascript-create-module/index.js Outdated
@GauBen GauBen requested a review from baptistegrimaud March 19, 2025 15:34
@GauBen GauBen enabled auto-merge (squash) March 19, 2025 15:35
@GauBen GauBen merged commit aeababf into main Mar 19, 2025
10 checks passed
@GauBen GauBen deleted the fix/hello-world branch March 19, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants