Skip to content

feat(library)!: made attributes default to false#187

Merged
GauBen merged 3 commits intomainfrom
feat/readOnly
Mar 17, 2025
Merged

feat(library)!: made attributes default to false#187
GauBen merged 3 commits intomainfrom
feat/readOnly

Conversation

@GauBen
Copy link
Copy Markdown
Member

@GauBen GauBen commented Mar 17, 2025

Description

Breaking change!

All attributes now default to false: instead of writing <Area editable={false}> you'd write <Area readOnly>

Closes #180

Checklist

Source code

  • I've considered the implications on security (in particular for changes to authentication, authorization, data fetching, ...)
  • I've considered the implications on performances
  • I've considered the implications on migration
  • I've considered the implications on code maintainability

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Documentation

  • I've provided inline documentation (Source code)
  • I've provided internal documentation (README, Confluence)
  • I've provided user-facing documentation (Academy)

Tip

Documentation to guide the reviews: How to do a code review

@GauBen GauBen self-assigned this Mar 17, 2025
@GauBen GauBen requested a review from a team as a code owner March 17, 2025 08:05
@baptistegrimaud baptistegrimaud changed the title feat!(library): made attributes default to false feat(library)!: made attributes default to false Mar 17, 2025
@GauBen GauBen merged commit 8fb4df7 into main Mar 17, 2025
@GauBen GauBen deleted the feat/readOnly branch March 17, 2025 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Attributes should be falsy by default and adding them will make them truthy

2 participants