Skip to content

fix(template): support windows#196

Merged
GauBen merged 2 commits intomainfrom
fix/win
Mar 19, 2025
Merged

fix(template): support windows#196
GauBen merged 2 commits intomainfrom
fix/win

Conversation

@GauBen
Copy link
Copy Markdown
Member

@GauBen GauBen commented Mar 19, 2025

Description

This is required to work on Windows with FNM (yarn is not a binary but a .ps1 script)

Checklist

Source code

  • I've considered the implications on security (in particular for changes to authentication, authorization, data fetching, ...)
  • I've considered the implications on performances
  • I've considered the implications on migration
  • I've considered the implications on code maintainability

Tests

  • I've provided Unit and/or Integration Tests
  • I've updated the parent issue with required manual validations

Documentation

  • I've provided inline documentation (Source code)
  • I've provided internal documentation (README, Confluence)
  • I've provided user-facing documentation (Academy)

Tip

Documentation to guide the reviews: How to do a code review

@GauBen GauBen requested a review from a team as a code owner March 19, 2025 15:03
Copy link
Copy Markdown
Contributor

@baptistegrimaud baptistegrimaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reducing the size of @jahia/vite-plugin from 123MB to probably a couple of KB 🙂

@GauBen GauBen enabled auto-merge (squash) March 19, 2025 15:29
@GauBen GauBen merged commit b7fa13d into main Mar 19, 2025
10 checks passed
@GauBen GauBen deleted the fix/win branch March 19, 2025 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants