feat!: Refactor <Area> and <ContentArea> components#199
Merged
baptistegrimaud merged 2 commits intomainfrom Mar 25, 2025
Merged
feat!: Refactor <Area> and <ContentArea> components#199baptistegrimaud merged 2 commits intomainfrom
baptistegrimaud merged 2 commits intomainfrom
Conversation
e87c087 to
2effeab
Compare
Contributor
Author
|
NB: the tests seem to fail because of Jahia/jcontent#1681 |
dgriffon
requested changes
Mar 24, 2025
Contributor
Author
It was actually decided to keep the existing |
GauBen
reviewed
Mar 24, 2025
GauBen
reviewed
Mar 24, 2025
GauBen
reviewed
Mar 24, 2025
GauBen
reviewed
Mar 24, 2025
GauBen
reviewed
Mar 24, 2025
GauBen
reviewed
Mar 24, 2025
e0f8887 to
8b9806b
Compare
Member
|
I pushed an update to the library readme, tell me if it's accurate |
GauBen
reviewed
Mar 24, 2025
GauBen
approved these changes
Mar 24, 2025
94825eb to
512fe01
Compare
dgriffon
approved these changes
Mar 24, 2025
512fe01 to
74dcecd
Compare
74dcecd to
d424f3c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #179.
Refactor and simplify
<Area>and<AbsoluteArea>components (with breaking changes!).Usages
To use a fixed JCR node content of a given page:
This would store (and create if it does not exist) the content node
yourContentNode(of type"jnt:contentList") as a child node ofyourPageNode(aJCRNodeWrapper).For instance, to use the
mainnode of the home page:Or to use a different page (at a custom hierarchy):
A content node relative to the current page can also be used:
Which is equivalent to use a classic
<Area>: