Skip to content

refactor: migrate jahia components to typescript#48

Merged
GauBen merged 1 commit intomainfrom
refactor/ts-2
Feb 7, 2025
Merged

refactor: migrate jahia components to typescript#48
GauBen merged 1 commit intomainfrom
refactor/ts-2

Conversation

@GauBen
Copy link
Copy Markdown
Member

@GauBen GauBen commented Feb 6, 2025

Description

Moving forward on #46, things go smoothly so far!

Tests

The following are included in this PR

  • Unit Tests (Most changes should have unit tests)
  • Integration Tests

Checklist

I have considered the following implications of my change:

  • Security (in particular for changes to authentication, authorization, data fetching, ...)
  • Performance
  • Migration
  • Code maintainability

Documentation

  • Inline documentation
  • Internal Documentation (wiki)
  • User-facing Documentation

@GauBen GauBen requested a review from a team as a code owner February 6, 2025 16:16
@GauBen
Copy link
Copy Markdown
Member Author

GauBen commented Feb 6, 2025

Btw I'm only porting JS to TS, I'd like more precise declarations in the future (e.g. AddResource could only allow media when type="css")

But that's for another day, it will be done step by step

@GauBen GauBen enabled auto-merge (squash) February 6, 2025 16:31
@GauBen GauBen merged commit 5bdd4c7 into main Feb 7, 2025
@GauBen GauBen deleted the refactor/ts-2 branch February 7, 2025 08:06
baptistegrimaud pushed a commit that referenced this pull request Feb 25, 2025
…cumentation (#48)

* BACKLOG-23209: remove handlebar, set module-type attribute, update documentation

* BACKLOG-23209: update replace in file (to fix windows issue)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants