Skip to content

feat: Typography with forwardRef #1055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ffffffelix merged 2 commits into from
Jun 10, 2025
Merged

feat: Typography with forwardRef #1055

ffffffelix merged 2 commits into from
Jun 10, 2025

Conversation

@ffffffelix
Copy link
Collaborator

@ffffffelix ffffffelix commented May 28, 2025

Description

  • Change Typography type to forwardRef
  • Update typography component

Tests

The following are included in this PR

  • Unit Tests
  • Accessibility is OK

Checklist

  • All files present (component - scss - spec - stories)
  • All props ok and documented (typescript types)
  • Required props, default values, variants and colors
  • Example in storybook
  • Reversed style (light/dark mode)
  • Allows custom props

@ffffffelix ffffffelix requested a review from abourgoindev May 28, 2025 13:25
@ffffffelix ffffffelix self-assigned this May 28, 2025
@ffffffelix ffffffelix added the minor Increment the minor version when merged label May 28, 2025
@ffffffelix ffffffelix merged commit 1f0eec1 into develop Jun 10, 2025
5 checks passed
@ffffffelix ffffffelix deleted the feat-typography-forwardRef branch June 10, 2025 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@abourgoindev abourgoindev abourgoindev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@ffffffelix ffffffelix

Labels

minor Increment the minor version when merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ffffffelix @abourgoindev