Skip to content

Fix: import get_display#1283

Merged
rkcosmos merged 1 commit intoJaidedAI:masterfrom
Yepness:master
Jul 25, 2024
Merged

Fix: import get_display#1283
rkcosmos merged 1 commit intoJaidedAI:masterfrom
Yepness:master

Conversation

@Yepness
Copy link
Copy Markdown
Contributor

@Yepness Yepness commented Jul 20, 2024

Fix get display import "from bidi import get_display" and no longer from "bidi.algorithm import get_display" this PR aim to fix that issue.

@Melanee-Melanee
Copy link
Copy Markdown

Melanee-Melanee commented Jul 22, 2024

Please install this version of python-bidi:

!pip install python-bidi==0.4.2

@vinsunkavalli
Copy link
Copy Markdown

vinsunkavalli commented Jul 22, 2024

@Yepness I think the requirements also need to be changed to reflect that easyocr only supports newer versions of python-bidi if this change is implemented?

@Yepness
Copy link
Copy Markdown
Contributor Author

Yepness commented Jul 22, 2024

@vinsunkavalli The current requirements reference the latest version of python-bidi, which includes the import adjustment. Therefore, there are two possible solutions:

  1. Adjust the code based on the latest version of the repository (PR).

  2. Modify the requirements to python-bidi==0.4.2 to use the currently deprecated import.

reformat_input_batched, merge_to_free
from .config import *
from bidi.algorithm import get_display
from bidi import get_display
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
from bidi import get_display
try:
from bidi import get_display
except:
from bidi.algoritm import get_display

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good idea to ensure backward compability!

Copy link
Copy Markdown

@darrenchang darrenchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the fix

reformat_input_batched, merge_to_free
from .config import *
from bidi.algorithm import get_display
from bidi import get_display
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems like a good idea to ensure backward compability!

Copy link
Copy Markdown

@darrenchang darrenchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can someone approve this

This was referenced Jul 24, 2024
Copy link
Copy Markdown

@sagarishere sagarishere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup, do this.

This is a critical issue to make the base library to be useful out of the box.

@sagarishere
Copy link
Copy Markdown

@JaidedTeam

@rkcosmos rkcosmos merged commit 3d3852d into JaidedAI:master Jul 25, 2024
@rkcosmos
Copy link
Copy Markdown
Contributor

Thanks everyone.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants