Add Windows ROCm build instructions to HIP (ROCm) section#130
Merged
Conversation
Owner
|
OK, Thank you for providing the documentation, which helps improve the system and better assist more AMD accelerator card users. If you feel there's nothing else to add, I'll merge it later. |
Author
Good to see you're open to adding this. I've maintained my fork for months now, it only had this single doc change. Haven't experienced compilation/stability issues, so I tweaked this line a bit as well. Now it's ready to be merged. |
Author
|
Thanks! If any Windows ROCm issues arise, feel free to ping me anytime. |
Owner
|
OK :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a collapsed
Windows ROCmsubsection inside the existingHIP (ROCm)details block.Why
The current HIP section only covers Linux. Windows users building with AMD's TheRock-based ROCm SDK (installed via pip into a venv) have no documented path. This adds one.
Verified working
Check build output with:
Output on test machine:
No existing behavior is affected. Linux ROCm users see no change. The new block is opt-in via click-to-expand.