Skip to content

Add Windows ROCm build instructions to HIP (ROCm) section#130

Merged
JamePeng merged 1 commit into
JamePeng:mainfrom
0xDELUXA:win-rocm-build
May 20, 2026
Merged

Add Windows ROCm build instructions to HIP (ROCm) section#130
JamePeng merged 1 commit into
JamePeng:mainfrom
0xDELUXA:win-rocm-build

Conversation

@0xDELUXA
Copy link
Copy Markdown

@0xDELUXA 0xDELUXA commented May 20, 2026

Summary

Adds a collapsed Windows ROCm subsection inside the existing HIP (ROCm) details block.

Why

The current HIP section only covers Linux. Windows users building with AMD's TheRock-based ROCm SDK (installed via pip into a venv) have no documented path. This adds one.

Verified working

Check build output with:

llama_cpp.llama_print_system_info().decode('utf-8')  # should contain "ROCm"
llama_cpp.llama_supports_gpu_offload()               # should return True

Output on test machine:

ggml_cuda_init: found 1 ROCm devices (Total VRAM: 16304 MiB):
  Device 0: AMD Radeon RX 9060 XT, gfx1200 (0x1200), ...
ROCm : NO_VMM = 1 | ...
GPU Offload Supported: True

No existing behavior is affected. Linux ROCm users see no change. The new block is opt-in via click-to-expand.

@JamePeng
Copy link
Copy Markdown
Owner

OK, Thank you for providing the documentation, which helps improve the system and better assist more AMD accelerator card users. If you feel there's nothing else to add, I'll merge it later.

@0xDELUXA
Copy link
Copy Markdown
Author

0xDELUXA commented May 20, 2026

OK, Thank you for providing the documentation, which helps improve the system and better assist more AMD accelerator card users. If you feel there's nothing else to add, I'll merge it later.

Good to see you're open to adding this. I've maintained my fork for months now, it only had this single doc change. Haven't experienced compilation/stability issues, so I tweaked this line a bit as well. Now it's ready to be merged.

@JamePeng JamePeng merged commit 35dfa34 into JamePeng:main May 20, 2026
8 checks passed
@0xDELUXA
Copy link
Copy Markdown
Author

Thanks! If any Windows ROCm issues arise, feel free to ping me anytime.

@JamePeng
Copy link
Copy Markdown
Owner

OK :)

@0xDELUXA 0xDELUXA deleted the win-rocm-build branch May 20, 2026 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants